Re: [PATCH v5 07/16] ima: Move ima_htable into ima_namespace

kernel test robot
2021-12-09T16:28:28Z

Hi Stefan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on zohar-integrity/next-integrity]
[also build test ERROR on linux/master linus/master v5.16-rc4]
[cannot apply to next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211209-062017
base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: arm64-randconfig-r031-20211208 (https://download.01.org/0day-ci/archive/20211210/202112100051.YVQaPaJf-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/312fc86ebd92ceacb9cb3575f961472132e6cb77
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211209-062017
git checkout 312fc86ebd92ceacb9cb3575f961472132e6cb77
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash security/integrity/ima/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> security/integrity/ima/ima_kexec.c:150:21: error: too few arguments to function call, expected 3, have 2
kexec_buffer);
^
security/integrity/ima/ima.h:169:5: note: 'ima_restore_measurement_list' declared here
int ima_restore_measurement_list(struct ima_namespace *ns,
^
1 error generated.

vim +150 security/integrity/ima/ima_kexec.c

7b8589cc29e7c3 Mimi Zohar 2016-12-19 136
94c3aac567a9dd Mimi Zohar 2016-12-19 137 /*
94c3aac567a9dd Mimi Zohar 2016-12-19 138 * Restore the measurement list from the previous kernel.
94c3aac567a9dd Mimi Zohar 2016-12-19 139 */
94c3aac567a9dd Mimi Zohar 2016-12-19 140 void ima_load_kexec_buffer(void)
94c3aac567a9dd Mimi Zohar 2016-12-19 141 {
94c3aac567a9dd Mimi Zohar 2016-12-19 142 void *kexec_buffer = NULL;
94c3aac567a9dd Mimi Zohar 2016-12-19 143 size_t kexec_buffer_size = 0;
94c3aac567a9dd Mimi Zohar 2016-12-19 144 int rc;
94c3aac567a9dd Mimi Zohar 2016-12-19 145
94c3aac567a9dd Mimi Zohar 2016-12-19 146 rc = ima_get_kexec_buffer(&kexec_buffer, &kexec_buffer_size);
94c3aac567a9dd Mimi Zohar 2016-12-19 147 switch (rc) {
94c3aac567a9dd Mimi Zohar 2016-12-19 148 case 0:
94c3aac567a9dd Mimi Zohar 2016-12-19 149 rc = ima_restore_measurement_list(kexec_buffer_size,
94c3aac567a9dd Mimi Zohar 2016-12-19 @150 kexec_buffer);

---
0-DAY CI Kernel Test Service, Intel Corporation