From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CD9C77B61 for ; Thu, 27 Apr 2023 11:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243290AbjD0LMy (ORCPT ); Thu, 27 Apr 2023 07:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243285AbjD0LMx (ORCPT ); Thu, 27 Apr 2023 07:12:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AEC4BB; Thu, 27 Apr 2023 04:12:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1600663CA5; Thu, 27 Apr 2023 11:12:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0679C433D2; Thu, 27 Apr 2023 11:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682593971; bh=tYEMYoMNhaeglO+EUKp0svEVZqDr0bFUZOa8BJPNQOM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=S2YQ7Cc5uN0lnBjyYBWdVbkKeQ40o2ye7kW1CSYWeM8n19WHMe5vC4oj2V2rBg2s7 nPZfd12wTF3IUw5v9jP9fJeJjv7q9rJ3Jm09TQD7bwUJmPnTL+Wyp10wITsdqxyJuf XSchTVaGaCWlmeR1fOro48QJSHjlWpYvVN9DEm00mjWvOqEOKMBq3+zRH7zg16jYD9 YeIjaVp4DimalPa/IqJ5jKL7ntCi4ICJWnFrZE1OVysg0GEYUn2JCAZagDVswRUeq2 XPEKIA++Ah0ZxhwfBUFAysWP0B1ytaLOXE94LG3Bms27oRVY4WJOn4OP1XvUak56yI x+yb34AcyhskA== Message-ID: <6e61385de6044932aabfc407ed8bc368f7e9631f.camel@kernel.org> Subject: Re: [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM drivers From: Jarkko Sakkinen To: Pengfei Xu Cc: linux-integrity@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Lino Sanfilippo , linux-kernel@vger.kernel.org, heng.su@intel.com Date: Thu, 27 Apr 2023 14:12:47 +0300 In-Reply-To: References: <20230426185833.289868-1-jarkko@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2023-04-27 at 13:52 +0300, Jarkko Sakkinen wrote: > On Thu, 2023-04-27 at 09:58 +0800, Pengfei Xu wrote: > > On 2023-04-26 at 21:58:33 +0300, Jarkko Sakkinen wrote: > > > TPM chip bootstrapping was removed from tpm_chip_register(), and it > > > was relocated to tpm_tis_core. This breaks all drivers which are not > > > based on tpm_tis because the chip will not get properly initialized. > > >=20 > > > Take the corrective steps: > > > 1. Rename tpm_chip_startup() as tpm_chip_bootstrap() and make it one-= shot. > > > 2. Call tpm_chip_bootstrap() in tpm_chip_register(), which reverts th= e > > > things as tehy used to be. > > ^ two space and one typo "they" > > Thanks for your fixed patch in short time! > >=20 > > And I tested this patch, it could not be reproduced in 155s, and the = patch > > fixed this issue. > > Fixed dmesg is in attached. > >=20 > > Tested-by: Pengfei Xu >=20 > Thanks a lot! I'll take immediate action to send PR to Linus. >=20 > Lino: no worries. It was expected that such a large refactorization > could break a thing or two. You did a good job in any case. Done: https://lkml.org/lkml/2023/4/27/297 BR, Jarkko