From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E87C433DF for ; Tue, 26 May 2020 21:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E93420888 for ; Tue, 26 May 2020 21:33:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GGjDmsOg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389747AbgEZVdQ (ORCPT ); Tue, 26 May 2020 17:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388740AbgEZVdP (ORCPT ); Tue, 26 May 2020 17:33:15 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A0BC061A0F; Tue, 26 May 2020 14:33:15 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id p30so10679871pgl.11; Tue, 26 May 2020 14:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j3hVOp0liWWCUJVNOiyTPzyXy/QJ2NvCerFTV87ycss=; b=GGjDmsOgTTiI7R3BLlJU0vbgxubrZ+ftnl+Kxc9bQzyy6vDvKwg9v/AqfXsXUU0IDK ZRplh83OMgY21yAFIstEpcR+9ctXjScECvQtGp22jjO/MuE7a0XBeSdKzDVBt0za/a1J tAH6yK88ahQBRMmXsqpZrBYXMBrzQ0UjkIW7mVcqm5MNRHQe3oypGxbI3H4tLns0wgyb 7ANZp1vnP3+ZOA9iirLWvk4DNmiOUycwOSIBDWNVImUXUqTnsL8arQgpIwdOZuXzZxC7 WzqKdRY267IApA3aeh9NSDrI1XQSegY6BDlvoovndg2aRxpRfXUv7qg8cPt4FbRSsbXr hYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j3hVOp0liWWCUJVNOiyTPzyXy/QJ2NvCerFTV87ycss=; b=CdtODL+iPgA4CEqWxyFU/e1fgpWDOEdko+o+3kTuO11Vy9swJXRIqCw/Yg1K2D75WS f0L1CFb8M0kJ9ddMvIA/HC6kcQHpj8NIoIveZz0jkrffTNqPN2Mebj5nZUjjTGhONOeY WDbc8pzI5r0Rz4WhyjLgPyAiLTaIb5EuXgor2qoLxPP4pw8qkDqYYg46zq14E6BlfLjS sUqi1idgeB23jygmh+P3HP2eSRU/WowSLUZpOLJgDyTPgtyFx5oKdE7zoj3ZYViq/Hfx jmbgh27/4yBVMnZMxwBkvs1/G2B7uM/h2rMelrXfZN2/uo393iSA9GoI5O3ZRWbocwmv 1xww== X-Gm-Message-State: AOAM532vWzOXnm5jBTYGKninDmO511EpXUlCOu2yg2Bo3xwYcl3D/F6h e2fT9FzpV9jHwl2dPVT00/LrFSGy7aY= X-Google-Smtp-Source: ABdhPJwadwvNjSPXipWEqKXGx3b6nE58nTZY95Z4jOnwtALHI/c2AodDJbsWEm+Ml1xxXssTWtL0Pg== X-Received: by 2002:a62:834b:: with SMTP id h72mr712713pfe.237.1590528794658; Tue, 26 May 2020 14:33:14 -0700 (PDT) Received: from [192.168.1.5] ([75.164.7.205]) by smtp.gmail.com with ESMTPSA id p1sm352318pjz.36.2020.05.26.14.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 14:33:13 -0700 (PDT) Subject: Re: [PATCH] tpm: Revert "tpm: fix invalid locking in NONBLOCKING mode" To: James Bottomley , Mario Limonciello , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffrin Jose T , Alex Guzman References: <20200526183213.20720-1-mario.limonciello@dell.com> <1590520454.11810.40.camel@HansenPartnership.com> <1590523214.15108.4.camel@HansenPartnership.com> From: Tadeusz Struk Message-ID: <705c9df6-e8cd-2829-c579-2bf039360eec@gmail.com> Date: Tue, 26 May 2020 14:33:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1590523214.15108.4.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 5/26/20 1:00 PM, James Bottomley wrote: > I don't think there is a root cause other than a TIS TPM is getting > annoyed by us cycling localities too rapidly because we don't do an > actual TPM operation between request and relinquish. Since the first > request/relinquish seems unnecessary for the async case, moving the ops > get eliminates the problem. Could be, so maybe we could try both patches. More debug info on the error path won't hurt. Thanks, Tadeusz