public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Ninad Palsule <ninad@linux.ibm.com>
To: Conor Dooley <conor@kernel.org>
Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	Joel Stanley <joel@jms.id.au>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v1 1/1] tpm: tis-i2c: Add more compatible strings
Date: Thu, 11 Jan 2024 10:43:08 -0600	[thread overview]
Message-ID: <77fe0ccd-53ff-4773-9787-0d038434297f@linux.ibm.com> (raw)
In-Reply-To: <20240109-saddling-nintendo-c7fbb46bb0dd@spud>

Hello Conor,

On 1/9/24 11:11, Conor Dooley wrote:
> On Thu, Dec 14, 2023 at 08:49:53AM -0600, Ninad Palsule wrote:
>> From: Joel Stanley <joel@jms.id.au>
>>
>> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>>
>> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>>
>> Add a compatible string for it, and the generic compatible.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>> Link: https://lore.kernel.org/r/20220928043957.2636877-4-joel@jms.id.au
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> I don't understand why you broke this series up and dropped patches.
> NAK, these compatibles are not documented.
>
The original series has three patches:

1) Adding compatibility string which I am adding in this series.

2) Adding schema for the TIS I2c devices which is already covered by 
Lukas's patch (already merged in linux-next) 
https://lore.kernel.org/all/3f56f0a2bb90697a23e83583a21684b75dc7eea2.1701093036.git.lukas@wunner.de/

3) Removing "Infineon,slb9673" from trivial-devices.yaml which is not 
done as it is already added in the TPM specific file. I will add it in 
my patch. Good catch!

Thanks for the review.

Regards,

Ninad


  reply	other threads:[~2024-01-11 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 14:49 [PATCH v1 0/1] Add more compatibility strings to tpm-tis-i2c Ninad Palsule
2023-12-14 14:49 ` [PATCH v1 1/1] tpm: tis-i2c: Add more compatible strings Ninad Palsule
2024-01-09 17:11   ` Conor Dooley
2024-01-11 16:43     ` Ninad Palsule [this message]
2024-01-12 17:24       ` Conor Dooley
2024-01-16 17:44         ` Ninad Palsule
2024-01-25 20:13         ` Ninad Palsule
2024-01-11 18:09     ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77fe0ccd-53ff-4773-9787-0d038434297f@linux.ibm.com \
    --to=ninad@linux.ibm.com \
    --cc=conor@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=joel@jms.id.au \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox