From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCDFC41513 for ; Thu, 10 Aug 2023 17:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234600AbjHJRsK (ORCPT ); Thu, 10 Aug 2023 13:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234097AbjHJRsJ (ORCPT ); Thu, 10 Aug 2023 13:48:09 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2B9A2710; Thu, 10 Aug 2023 10:48:08 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E91F21868; Thu, 10 Aug 2023 17:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691689687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+SALt3KKFkqGY0oTDLJNY4pYAiWhcYL3HYO3+3lMkDU=; b=GkiWu/5jAQrbufBuDaePQ40Ns6wXvgqYIdP3GRzTbBOpvnvFCNc3LQ+0k5sJoeng8HMJbz FZj016pEBkQZvYabc98MhZGk6wUTcn+EcS58CpzGTtuA5VoCyx6h90HntjySdiQBRamc8x IhR3xj8KuRdY/FWRwLaRkhOu6IeXAxU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691689687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+SALt3KKFkqGY0oTDLJNY4pYAiWhcYL3HYO3+3lMkDU=; b=6m/pimEe3rVv3rPslkzetVhyJ2YqvAm+nw8aMvsuW9ftpcDAWZCQaJ0uzvu2BFHHoX+w1I en031peYCaLgnmAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 50071138E2; Thu, 10 Aug 2023 17:48:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8ZkwEtci1WRDWQAAMHmgww (envelope-from ); Thu, 10 Aug 2023 17:48:07 +0000 Date: Thu, 10 Aug 2023 19:48:06 +0200 Message-ID: <875y5mu6uh.wl-tiwai@suse.de> From: Takashi Iwai To: "Jarkko Sakkinen" Cc: "Takashi Iwai" , "Peter Huewe" , "Jason Gunthorpe" , , Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for Lenovo Thinkpad E14 Gen 2 and 13s-IML In-Reply-To: References: <20230807140125.18486-1-tiwai@suse.de> <87il9qhxjq.wl-tiwai@suse.de> <87ttt7rkpq.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 10 Aug 2023 19:35:16 +0200, Jarkko Sakkinen wrote: > > On Thu Aug 10, 2023 at 6:16 PM EEST, Takashi Iwai wrote: > > On Thu, 10 Aug 2023 17:08:04 +0200, > > Jarkko Sakkinen wrote: > > > > > > On Tue Aug 8, 2023 at 9:12 AM EEST, Takashi Iwai wrote: > > > > On Mon, 07 Aug 2023 21:14:20 +0200, > > > > Jarkko Sakkinen wrote: > > > > > > > > > > On Mon Aug 7, 2023 at 2:01 PM UTC, Takashi Iwai wrote: > > > > > > Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML > > > > > > also require to disable the tpm_tis interrupts for avoiding a boot > > > > > > hang. > > > > > > > > > > > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > > > > > Cc: # v6.4+ > > > > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213779 > > > > > > Signed-off-by: Takashi Iwai > > > > > > > > > > > > --- > > > > > > drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ > > > > > > 1 file changed, 16 insertions(+) > > > > > > > > > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > > > > > index a98773ac2e55..0633823dc515 100644 > > > > > > --- a/drivers/char/tpm/tpm_tis.c > > > > > > +++ b/drivers/char/tpm/tpm_tis.c > > > > > > @@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > > > > > DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), > > > > > > }, > > > > > > }, > > > > > > + { > > > > > > + .callback = tpm_tis_disable_irq, > > > > > > + .ident = "ThinkPad E14 Gen 2", > > > > > > + .matches = { > > > > > > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > > > > > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), > > > > > > + }, > > > > > > + }, > > > > > > + { > > > > > > + .callback = tpm_tis_disable_irq, > > > > > > + .ident = "ThinkBook 13s-IML", > > > > > > + .matches = { > > > > > > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > > > > > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), > > > > > > + }, > > > > > > + }, > > > > > > { > > > > > > .callback = tpm_tis_disable_irq, > > > > > > .ident = "ThinkPad T490s", > > > > > > -- > > > > > > 2.35.3 > > > > > > > > > > As almost all issues are with Lenovo, I would instead just put: > > > > > > > > > > { > > > > > .callback = tpm_tis_disable_irq, > > > > > .matches = { > > > > > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > > > > }, > > > > > }, > > > > > > > > > > And delete the existing entries with vendor as "LENOVO". > > > > > > > > Yeah, that will relieve pains better, too. > > > > > > Please do it if possible then :-) > > > > Do you mean that I should resubmit a new patch? > > Honestly speaking, it'd be easier if you can do it directly. > > I'm merely a sort of messenger, I don't own / test the device by > > myself... > > > > But if inevitably required, I can resubmit a patch, of course. > > I'll submit a patch asap, and cc you. I put the conclusions > to the description. Great, thanks! Takashi