From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2773C433E6 for ; Fri, 12 Feb 2021 03:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7896064E62 for ; Fri, 12 Feb 2021 03:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhBLDWm (ORCPT ); Thu, 11 Feb 2021 22:22:42 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:4730 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229771AbhBLDWj (ORCPT ); Thu, 11 Feb 2021 22:22:39 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 11C32pBA118665; Thu, 11 Feb 2021 22:21:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : mime-version : content-type; s=pp1; bh=fwDZeUoijbyh0Cz4tGW+Nt5SVTHfeTV0O0nxlCJ/Ax4=; b=Gcxb9P9Qtfz+B3q9sg+LhXfBb6hblSACnHW+O5X+lloanbDnJEE8zsxG7DoOShLhU3ht 3Pyp2z9O08d6WK6oqAqLjJAOeA1zPCfCmSHzoSrxoSmc+kl+WJgHansU5sWTky6o2CE4 Y2HQFbOShr6n3NfAF6/TCE3HUUUg4QCRiSbh0rxG36h1FQ4dypJtYpGo/Fl2xIPSwN7f zxhJr3C2SrsrjV+accR4dyBsQpsrO4edRqR27r7tnHjuFkFQu/K6aIFkflOl6AzTeVhW ZyhMHxIfnZIfrXhihKLmp4Gb3xStLn5OenGlqNnPgTjCSAnn3nqyo0S+ouI5XpdGumND UA== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 36nh4brnrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 22:21:44 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11C3Dbs0028832; Fri, 12 Feb 2021 03:21:44 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04dal.us.ibm.com with ESMTP id 36hjra4yv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Feb 2021 03:21:44 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11C3Lhg634865542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Feb 2021 03:21:43 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C9FBAC059; Fri, 12 Feb 2021 03:21:43 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CF119AC05B; Fri, 12 Feb 2021 03:21:41 +0000 (GMT) Received: from manicouagan.localdomain (unknown [9.85.204.73]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Fri, 12 Feb 2021 03:21:41 +0000 (GMT) References: <202102120032.Bv0MoYv7-lkp@intel.com> <40fd1869-dcb4-36ae-e997-b8486dd4846c@linux.microsoft.com> <87mtwap35f.fsf@manicouagan.localdomain> <87eehmox08.fsf@manicouagan.localdomain> User-agent: mu4e 1.4.10; emacs 27.1 From: Thiago Jung Bauermann To: Lakshmi Ramasubramanian Cc: Rob Herring , Mimi Zohar , linux-arm-kernel , linux-integrity@vger.kernel.org, linuxppc-dev Subject: Re: Fwd: Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function In-reply-to: Date: Fri, 12 Feb 2021 00:21:39 -0300 Message-ID: <87blcqotrw.fsf@manicouagan.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-11_07:2021-02-11,2021-02-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102120018 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Lakshmi Ramasubramanian writes: > On 2/11/21 6:11 PM, Thiago Jung Bauermann wrote: >> Lakshmi Ramasubramanian writes: >> >>> On 2/11/21 3:59 PM, Thiago Jung Bauermann wrote: >>>> Lakshmi Ramasubramanian writes: >>>> >>>>> On 2/11/21 9:42 AM, Lakshmi Ramasubramanian wrote: >>>>>> Hi Rob, >>>>>> [PATCH] powerpc: Rename kexec elfcorehdr_addr to elf_headers_mem >>>>>> This change causes build problem for x86_64 architecture (please see the >>>>>> mail from kernel test bot below) since arch/x86/include/asm/kexec.h uses >>>>>> "elf_load_addr" for the ELF header buffer address and not >>>>>> "elf_headers_mem". >>>>>> struct kimage_arch { >>>>>> ... >>>>>> /* Core ELF header buffer */ >>>>>> void *elf_headers; >>>>>> unsigned long elf_headers_sz; >>>>>> unsigned long elf_load_addr; >>>>>> }; >>>>>> I am thinking of limiting of_kexec_alloc_and_setup_fdt() to ARM64 and >>>>>> PPC64 since they are the only ones using this function now. >>>>>> #if defined(CONFIG_ARM64) && defined(CONFIG_PPC64) >>>>> Sorry - I meant to say >>>>> #if defined(CONFIG_ARM64) || defined(CONFIG_PPC64) >>>>> >>>> Does it build correctly if you rename elf_headers_mem to elf_load_addr? >>>> Or the other way around, renaming x86's elf_load_addr to >>>> elf_headers_mem. I don't really have a preference. >>> >>> Yes - changing arm64 and ppc from "elf_headers_mem" to "elf_load_addr" builds >>> fine. >>> >>> But I am concerned about a few other architectures that also define "struct >>> kimage_arch" such as "parisc", "arm" which do not have any ELF related fields. >>> They would not build if the config defines CONFIG_KEXEC_FILE and >>> CONFIG_OF_FLATTREE. >>> >>> Do you think that could be an issue? >> That's a good point. But in practice, arm doesn't support >> CONFIG_KEXEC_FILE. And while parisc does support CONFIG_KEXEC_FILE, as >> far as I could determine it doesn't support CONFIG_OF. >> So IMHO we don't need to worry about them. We'll cross that bridge if we >> get there. If they ever implement KEXEC_FILE or OF_FLATTREE support, >> then (again, IMHO) the natural solution would be for them to name the >> ELF header member the same way the other arches do. >> And since no other architecture defines struct kimage_arch, those are >> the only ones we need to consider. >> > > Sounds good Thiago. > > I'll rename arm64 and ppc kimage_arch ELF address field to match that defined > for x86/x64. > > Also, will add "fdt_size" param to of_kexec_alloc_and_setup_fdt(). For now, I'll > use 2*fdt_totalsize(initial_boot_params) for ppc. > > Will send the updated patches shortly. Sounds good. There will be a small conflict with powerpc/next because of the patch I mentioned, but it's simple to fix by whoever merges the series. -- Thiago Jung Bauermann IBM Linux Technology Center