From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6A1C433E0 for ; Thu, 25 Feb 2021 11:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 753FE64F1B for ; Thu, 25 Feb 2021 11:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232778AbhBYLuv (ORCPT ); Thu, 25 Feb 2021 06:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbhBYLut (ORCPT ); Thu, 25 Feb 2021 06:50:49 -0500 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0769C06174A; Thu, 25 Feb 2021 03:50:08 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4DmWLG6r0dz9sVF; Thu, 25 Feb 2021 22:49:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1614253805; bh=/SYtgE5qENlSC96VzcIwZTaGUmL6HCYNrQHwHPYZSs4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iSkCaS/DJVPQlH0gbL+LD45kazqnKgdUXrGSiY0t5rVH7XgWyEZ3dVcZQMrrdzWxb 5MgqcVG9pQkFcrHW+MXEpmHj5iL5Dc/O0Q3xerdpbA7nNL2QioWinUYOGNO1CftmBu foAGxV0uCzTC0mgQqEJOVDt+y1/5VQz2b92Jel0/OqIMCucyj2A49/JmP77ew5X9ex 7ocZxtF4Q7Ij1XMzTR+G4KGixhAD12BQzG5y3VyTqzm+g5IL6UR67JPFL4nCBTOTxL 1NBGWLbvxkYV3zB/XybDZ47lwrc8H7FUaYmZhnqcTWr1RcqeZBKCgq+EBQqZHvNLXS lfxhg1WNI9+Mg== From: Michael Ellerman To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Jens Axboe , Matt Mackall , Herbert Xu , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Haren Myneni , Breno =?utf-8?Q?Leit?= =?utf-8?Q?=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Steven Royer , Arnd Bergmann , Greg Kroah-Hartman , Cristobal Forno , Jakub Kicinski , Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Tyrel Datwyler , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Cyr , Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH v2] vio: make remove callback return void In-Reply-To: <20210224072516.74696-1-uwe@kleine-koenig.org> References: <20210224072516.74696-1-uwe@kleine-koenig.org> Date: Thu, 25 Feb 2021 22:49:54 +1100 Message-ID: <87sg5ks6xp.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Uwe Kleine-K=C3=B6nig writes: > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All users already unconditionally return 0, this commit makes > it obvious that returning an error code is a bad idea and makes it > obvious for future driver authors that returning an error code isn't > intended. > > Note there are two nominally different implementations for a vio bus: > one in arch/sparc/kernel/vio.c and the other in > arch/powerpc/platforms/pseries/vio.c. I didn't care to check which > driver is using which of these busses (or if even some of them can be > used with both) and simply adapt all drivers and the two bus codes in > one go. I'm 99% sure there's no connection between the two implementations, other than the name. So splitting the patch by arch would make it easier to merge. I'm reluctant to merge changes to sparc code. The list of powerpc specific drivers is: drivers/char/hw_random/pseries-rng.c drivers/char/tpm/tpm_ibmvtpm.c drivers/crypto/nx/nx-842-pseries.c drivers/crypto/nx/nx.c drivers/misc/ibmvmc.c drivers/net/ethernet/ibm/ibmveth.c drivers/net/ethernet/ibm/ibmvnic.c drivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvscsi.c drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c drivers/tty/hvc/hvcs.c cheers