From: Andrew Donnellan <ajd@linux.ibm.com>
To: Srish Srinivasan <ssrish@linux.ibm.com>,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen@kernel.org,
zohar@linux.ibm.com, nayna@linux.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management
Date: Mon, 12 May 2025 19:55:26 +1000 [thread overview]
Message-ID: <9477e99aa57e432b1e55ebd3e903036e60926014.camel@linux.ibm.com> (raw)
In-Reply-To: <2b7145a2-1cfb-4b1a-929c-10a03747119e@linux.ibm.com>
On Wed, 2025-05-07 at 00:29 +0530, Srish Srinivasan wrote:
> > I think you should handle this as the existing code does: if it's
> > ENOENT, return 0, and for other codes print an error and return -
> > EIO.
> Currently, the other layers in the boot stack assume static key mode
> for
> any failure in reading SB_VERSION. We added the same interpretation
> in the kernel to keep it consistent with the other layers, and
> represent
> the same to the user. This is the reason for not parsing the error
> codes
> when trying to read SB_VERSION, and defaulting to the static key
> management mode. However, we want the exact error code to be logged
> for debugging purposes. And, it does make sense to have logging only
> for
> error codes other than -ENOENT and -EPERM, as you suggested.
> Does this sound okay?
Okay, maybe document explicitly in a comment that we default to static
mode in the event of any weird errors.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2025-05-12 9:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 9:03 [PATCH 0/3] Enhancements to the secvar interface in static key management mode Srish Srinivasan
2025-04-30 9:03 ` [PATCH 1/3] powerpc/pseries: Correct secvar format representation for static key management Srish Srinivasan
2025-04-30 15:20 ` Nayna Jain
2025-05-05 8:36 ` Andrew Donnellan
2025-05-06 18:59 ` Srish Srinivasan
2025-05-07 6:17 ` Andrew Donnellan
2025-05-07 15:48 ` Srish Srinivasan
2025-05-12 9:51 ` Andrew Donnellan
2025-05-12 9:55 ` Andrew Donnellan [this message]
2025-05-12 10:16 ` Srish Srinivasan
2025-05-06 19:27 ` Nayna Jain
2025-05-07 6:03 ` Andrew Donnellan
2025-04-30 9:03 ` [PATCH 2/3] powerpc/secvar: Expose secvars relevant to the key management mode Srish Srinivasan
2025-04-30 15:22 ` Nayna Jain
2025-05-05 7:23 ` Andrew Donnellan
2025-05-06 19:00 ` Srish Srinivasan
2025-04-30 9:03 ` [PATCH 3/3] integrity/platform_certs: Allow loading of keys in static " Srish Srinivasan
2025-04-30 15:22 ` Nayna Jain
2025-05-05 7:55 ` Andrew Donnellan
2025-05-06 19:00 ` Srish Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9477e99aa57e432b1e55ebd3e903036e60926014.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ssrish@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).