From: Mimi Zohar <zohar@linux.ibm.com>
To: steven chen <chenste@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com,
eric.snowberg@oracle.com, corbet@lwn.net, serge@hallyn.com,
paul@paul-moore.com, jmorris@namei.org,
linux-security-module@vger.kernel.org,
anirudhve@linux.microsoft.com, gregorylumen@linux.microsoft.com,
nramas@linux.microsoft.com, sushring@linux.microsoft.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH V2 1/1] IMA event log trimming
Date: Tue, 23 Dec 2025 17:32:34 -0500 [thread overview]
Message-ID: <9a26898f46406314be1308e5416c0d51cedf44a4.camel@linux.ibm.com> (raw)
In-Reply-To: <b9d7bcea-3784-4ad6-b494-374db0c00cc6@linux.microsoft.com>
On Tue, 2025-12-16 at 11:59 -0800, steven chen wrote:
> > > > +{
> > > > + struct ima_queue_entry *qe, *qe_tmp;
> > > > + LIST_HEAD(ima_measurements_staged);
> > > > + unsigned int i;
> > > > + long cur = number_logs;
> > The variable name "number_logs" is confusing. As I mentioned in the patch
> > description, there is one measurement list with multiple records. There aren't
> > multiple logs in the kernel (other than the staged list).
>
> Will update it to "req_value". Thanks!
Please refer to the section titled "Naming" in Documentation/process/coding-
style.rst. Since this is the number of records being deleted, perhaps a better
variable name would be "num_records".
--
thanks,
Mimi
next prev parent reply other threads:[~2025-12-23 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 23:53 [PATCH v2 0/1] Trim N entries of IMA event logs steven chen
2025-12-10 23:53 ` [PATCH V2 1/1] IMA event log trimming steven chen
2025-12-11 10:14 ` Roberto Sassu
2025-12-11 18:20 ` steven chen
2025-12-11 18:41 ` steven chen
2025-12-16 12:50 ` Mimi Zohar
2025-12-16 19:59 ` steven chen
2025-12-23 22:32 ` Mimi Zohar [this message]
2026-01-02 14:33 ` steven chen
2025-12-15 14:02 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a26898f46406314be1308e5416c0d51cedf44a4.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=anirudhve@linux.microsoft.com \
--cc=chenste@linux.microsoft.com \
--cc=corbet@lwn.net \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=gregorylumen@linux.microsoft.com \
--cc=jmorris@namei.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sushring@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox