public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Jerry Snitselaar" <jsnitsel@redhat.com>
Cc: <peterhuewe@gmx.de>, <jgg@ziepe.ca>,
	<linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<l.sanfilippo@kunbus.com>
Subject: Re: [PATCH - for 6.4] tpm: tpm_tis: Disable interrupts for AEON UPX-i11
Date: Wed, 24 May 2023 05:50:27 +0300	[thread overview]
Message-ID: <CSU6091FJLXS.3MMTQQFUENGKB@suppilovahvero> (raw)
In-Reply-To: <2c94260b-ac97-3f5e-331b-76f1a17ec5b5@linux.intel.com>

On Mon May 22, 2023 at 10:40 AM EEST, Péter Ujfalusi wrote:
>
> On 18/05/2023 23:24, Péter Ujfalusi wrote:
> > 
> > The version is used to differentiate the revisions of the UPX-i11
> > boards, and this issue present in all revisions.
> > 
> >> I can squash this to the commit I pushed (it is not yet mirrored
> >> to linux-next), if I get the dmidecode info.
> > 
> > System Information
> >         Manufacturer: AAEON
> >         Product Name: UPX-TGL01
> >         Version: V1.0
> >         Serial Number: Default string
> >         UUID: a300091d-fb1c-ce1c-1d30-0007328efc11
> >         Wake-up Type: Power Switch
> >         SKU Number: Default string
> >         Family: Default string
> > 
> > I have used this description as it it is used for SOF, probably
> > DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> > should be added?
>
> Jarkko: I have tested that adding the
> DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> works.
>
> I would also do a small update to commit message: "120000 jiffies"  to
> "120000 msec".
> On my setup 120000 msec ends up to be 120000 jiffies.
>
> How do you prefer to handle this?
> I can send a v2 on top of linux-next / mainline
> I can send a fixup patch which can be squashed to the patch you have in
> your master branch atm
> Or you add this line by yourself?
>
> Either way is fine for me, whichever works best for you.

If you want to send a follow-up please do, and I can pick it.

BR, Jarkko

  reply	other threads:[~2023-05-24  2:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 12:29 [PATCH - for 6.4] tpm: tpm_tis: Disable interrupts for AEON UPX-i11 Peter Ujfalusi
2023-05-17 13:15 ` Péter Ujfalusi
2023-05-18 18:37 ` Jarkko Sakkinen
2023-05-18 18:47   ` Jarkko Sakkinen
2023-05-18 18:50 ` Jerry Snitselaar
2023-05-18 18:53   ` Jarkko Sakkinen
2023-05-18 20:24     ` Péter Ujfalusi
2023-05-22  7:40       ` Péter Ujfalusi
2023-05-24  2:50         ` Jarkko Sakkinen [this message]
2023-05-24  2:24       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CSU6091FJLXS.3MMTQQFUENGKB@suppilovahvero \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jsnitsel@redhat.com \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox