From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37DEC001E0 for ; Thu, 10 Aug 2023 19:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233152AbjHJTCm (ORCPT ); Thu, 10 Aug 2023 15:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233587AbjHJTCm (ORCPT ); Thu, 10 Aug 2023 15:02:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A9D926A6 for ; Thu, 10 Aug 2023 12:02:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 947E965A95 for ; Thu, 10 Aug 2023 19:02:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19280C433C8; Thu, 10 Aug 2023 19:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691694161; bh=NY1I/dGI6UjUjngthuJO6+5tb/YxG07vRQFk0si4eqM=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=K7zgAIo/MSZeXZZIpzOBp1iwLNxOOPzGd2a+YwWwjpzDPA+g+t5dUbEhfmXHWy0yp eJoAB+Uyo6zgOYpK75zmlLMF7as+y/iP5cYFluYm//eGLQKgjqWP2X7G5g1blBIEoT r7MXemTTn7BWFeCy+gGElbQ+ebVvMCDMxgyU9+oirzfyUOp69T9IjtfjkzJ1uHYv7e dIO6WP2xsy6mK9CEO1Ji4Fzfhrdq0COzJkeboVWqATi9lJ5WBtt5BdjT3cmj8uj6t2 F38PEgp0PFWgG6jshoHx4GJ2fNof27FRQ0fBzjS6nkpZTbHv86muFj17Ars0siqWhy 8v2NtOpnxxdVw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 10 Aug 2023 22:02:36 +0300 Message-Id: Cc: "linux-integrity@vger.kernel.org" Subject: Re: Build failure on tpmdd master branch From: "Jarkko Sakkinen" To: "Nayna" X-Mailer: aerc 0.14.0 References: In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue Aug 8, 2023 at 4:40 PM EEST, Nayna wrote: > Hi Jarkko, > > I rebased the "Enable loading local and third party keys on PowerVM=20 > guest"(=20 > https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linu= x.ibm.com/)=20 > on top of tpmdd master branch. > > The build is failing due to commit cfa7522f280a ("sysctl: set variable=20 > key_sysctls storage-class-specifier to static"). A patch with the same=20 > subject line is already in your tree. Refer to commit 0de030b30823=20 > ("sysctl: set variable key_sysctls storage-class-specifier to static"). > > Thanks & Regards, > > =C2=A0=C2=A0=C2=A0=C2=A0 - Nayna Thanks for reporting, I rebased my tree and did: make ARCH=3Dpowerpc CROSS_COMPILE=3Dpowerpc64-linux-gnu- defconfig make ARCH=3Dpowerpc CROSS_COMPILE=3Dpowerpc64-linux-gnu- I get this now: security/integrity/ima/ima_crypto.c: In function =E2=80=98ima_pcrread=E2=80= =99: security/integrity/ima/ima_crypto.c:785:13: error: too few arguments to fun= ction =E2=80=98tpm_pcr_read=E2=80=99 785 | if (tpm_pcr_read(ima_tpm_chip, idx, d) !=3D 0) | ^~~~~~~~~~~~ In file included from security/integrity/ima/ima.h:21, from security/integrity/ima/ima_crypto.c:23: ./include/linux/tpm.h:428:12: note: declared here 428 | extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx, | ^~~~~~~~~~~~ BTW, in future, please also provide both arch and .config. I made my guesses because I had neither (not meaning to complain, just telling what would be useful, no worries). BR, Jarkko