Re: [PATCH v2 4/4] tpm: tis_i2c: Add compatible string nuvoton,npct75x

Jarkko Sakkinen
2024-01-13T21:55:35Z

On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote:
> Add "nuvoton,npct75x" as well as the fallback compatible string
> "tcg,tpm-tis-i2c" to the TPM TIS I²C driver. They're used by:
>
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
>
> And by all accounts, NPCT75x is supported by the driver:
>
> https://lore.kernel.org/all/60e23fd0f0ff4d1f8954034237ae8865@NTILML02.nuvoton.com/
> https://lore.kernel.org/all/20220808220839.1006341-8-peter@pjd.dev/
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
> drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index a897402..9511c0d 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -383,6 +383,8 @@ static void tpm_tis_i2c_remove(struct i2c_client *client)
> #ifdef CONFIG_OF
> static const struct of_device_id of_tis_i2c_match[] = {
> { .compatible = "infineon,slb9673", },
> + { .compatible = "nuvoton,npct75x", },
> + { .compatible = "tcg,tpm-tis-i2c", },
> {}
> };
> MODULE_DEVICE_TABLE(of, of_tis_i2c_match);

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko