Re: [PATCH v2 3/4] tpm_tis: Add compatible string atmel,at97sc3204

Jarkko Sakkinen
2024-01-13T21:55:01Z

On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote:
> Commit 420d439849ca ("tpm_tis: Allow tpm_tis to be bound using DT")
> added the fallback compatible "tcg,tpm-tis-mmio" to the TPM TIS driver,
> but not the chip-specific "atmel,at97sc3204". However it did document
> it as a valid compatible string.
>
> Add it to tis_of_platform_match[] for consistency.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> ---
> drivers/char/tpm/tpm_tis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 2c52b79..14652aa 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -347,6 +347,7 @@ static void tpm_tis_plat_remove(struct platform_device *pdev)
>
> #ifdef CONFIG_OF
> static const struct of_device_id tis_of_platform_match[] = {
> + {.compatible = "atmel,at97sc3204"},
> {.compatible = "tcg,tpm-tis-mmio"},
> {},
> };

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko