Re: [PATCH v8 18/22] tpm: add session encryption protection to tpm2_get_random()

Herbert Xu
2024-05-18T12:31:17Z

On Sat, May 18, 2024 at 01:56:44PM +0300, Jarkko Sakkinen wrote:
>
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -36,6 +36,8 @@ config TCG_TPM2_HMAC
> bool "Use HMAC and encrypted transactions on the TPM bus"
> default y
> + select CRYPTO_DRBG
> select CRYPTO_ECDH
> + select CRYPTO_HMAC
> + select CRYPTO_SHA512
> select CRYPTO_LIB_AESCFB
> select CRYPTO_LIB_SHA256
> help

This isn't necessary because ECDH selects ECC which already
selects the DRBG and all the required algorithms.

You can verify this with the failing .config file as it has
everything needed built into the kernel (which is in fact
where the problem is).

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt