From: "Jarkko Sakkinen" <jarkko.sakkinen@iki.fi>
To: "James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Jarkko Sakkinen" <jarkko@kernel.org>
Cc: <linux-integrity@vger.kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Joe Hattori" <joe@pf.is.s.u-tokyo.ac.jp>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Andy Liang" <andy.liang@hpe.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Mimi Zohar" <zohar@linux.ibm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Map the ACPI provided event log
Date: Sun, 22 Dec 2024 17:23:28 +0200 [thread overview]
Message-ID: <D6IBZOIZPHG9.33MA1XLBELFNF@iki.fi> (raw)
In-Reply-To: <e8037b6dd77c3105ac94e0fe68aad39e9f3b9656.camel@HansenPartnership.com>
On Sun Dec 22, 2024 at 5:00 PM EET, James Bottomley wrote:
> If event logs grow to greater than KMALLOC_MAX_SIZE then absolutely it
> makes sense to map them instead of copying them. But we'd have to do
> that for all event log locators: ACPI, EFI and OF, because event log
> size should be independent of the mechanism used to locate it. So,
> even as a long term fix (assuming we think there's a possibility of
> logs expanding by 50x), this patch doesn't do the right thing because
> it only maps ACPI logs.
Because we have a test target only on ACPI where this happens fix
should still fix only ACPI. It's not hard to reiterate this but
precursory iteration is a bad idea.
BR, Jarkko
next prev parent reply other threads:[~2024-12-22 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 11:33 [PATCH] tpm: Map the ACPI provided event log Jarkko Sakkinen
2024-12-21 16:04 ` Ard Biesheuvel
2024-12-21 17:16 ` James Bottomley
2024-12-21 20:11 ` Jarkko Sakkinen
2024-12-21 20:13 ` Jarkko Sakkinen
2024-12-22 15:00 ` James Bottomley
2024-12-22 15:23 ` Jarkko Sakkinen [this message]
2024-12-22 15:33 ` Jarkko Sakkinen
2024-12-22 17:41 ` James Bottomley
2024-12-22 22:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6IBZOIZPHG9.33MA1XLBELFNF@iki.fi \
--to=jarkko.sakkinen@iki.fi \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andy.liang@hpe.com \
--cc=ardb@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=stefanb@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox