From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6009039A06B for ; Wed, 1 Jul 2026 06:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782886197; cv=none; b=MaFE/N0hapkBRq+fxGy2UXfAEd8/8pw7CyU+dugnJqlncfHKpWginlMnp2YqANUUKAYgIn49Ti6emruhgtu8VE2G/pcX9ctXeaQaSYGFwsEJm3pdNRiUplCixIJAOn3UWOgw8iBG16xHvzMsAnJdqLZOXZiLCbUsZ4lTwPgUYN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782886197; c=relaxed/simple; bh=6KbUYY4Kud4/SPqyi3x2WMVAQjlqAWpfU8+H8Iqg4wE=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SwJ78SGy068oRzeFJagbdjzt466AC59TQVfAu+uHK4NHsyGXd2x3E/M/a40hyRJx9jV/2/M2491Bt9m4XIUiE3d03V7fBMYKL6vC5I+AITB0n97tc9j00s4Af3BvmKFCduzaoMaNfXN4voKc/ZjUH8s+I3vRoumQTE5HxvJI77k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qPALaJxL; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qPALaJxL" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-44847520d7cso168758fac.1 for ; Tue, 30 Jun 2026 23:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782886195; x=1783490995; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qHk2CYv9CFjND1DA8+37qjWHNRV+096bhWS2yVE+OC0=; b=qPALaJxL49eCojqqTZcH7dHmncs/Z/anbHriboVoEHKtv72PkXZU0V5uGQaQ2N9wWZ nMp/GCLkq7cY2sl+E5E/scOov1FYElc45jgJ27fx6ejdC8pkUVS1a/0+34DLXzVHEM5j piCjbnymC6RWYRuQmTy/BpHobJ8E4w9cdxFYAabB6zrcMKc/kSO0n/f7+SvPDQPZrjiS pUgYH2ZRd2f4sWpr4eWfGsC7+k7w/cp+wVhGIBw7zI2zt8gmGpcuA03TsTLaqDTNoMN6 JI/BEfzJp4aZSNpJ4DG0p4FeEjjnBQ+gDPdZU1OefWVPcZssIrAYOwE5xiQxMiILwdyY urUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782886195; x=1783490995; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qHk2CYv9CFjND1DA8+37qjWHNRV+096bhWS2yVE+OC0=; b=G3u1FdBTtGUAfWnCPFl+f6joa1cemCdbMLv/FT3rB/rXuMJTc3PChIjPzxvQG9NmTn w2lUFSBx1KeNFSVuY1TSRWYByzhwkVVQK0KRNim5loBcO6GbkJzYyxw+YqQagCNJxOJk uBiZoykFm3QjTK4dA8dDP8PtiSXhZRlSqG7M7/l3vPUuh2AfK9pRt6EDeePWDTRSIYRf OnHD4AhGgEGRxgZH3SCRo5FeyXWfqtf9HHij0wZtJLCbdajv3Zz7JeFCAmZpptqYR5xX o/x0ZlX4u9U9q7qScV1Pqhj/B29QyTUyoMysr1IuWVEMyqUgQ5In2grgW19TB+3k/yBE QYew== X-Forwarded-Encrypted: i=1; AHgh+Rq2fypy2WZQIeNmrq9Po8dFg0ilNfNqHQS5e80Tm85xgEiQAMm3IOm9tOt6TjFi898Rg7FRGRucbqUAD2gx3T0=@vger.kernel.org X-Gm-Message-State: AOJu0YwRv7hqUMOM983C6C8DTbDu6DzBcorrK3nKsCWpuIjcB/NvHoy6 b5i72Odtn1rWxr7AS6hQKFfPMvB6vJUfmD1gna0Xb7EclWkYXs46sfEu X-Gm-Gg: AfdE7clE1EpSJtlCtpz5h0aKul+nZ6Uak6x6ytPyoeedDsG2wrCIhb+DYXPw1hqgaSx 7NCT3rXrsL7FL9xn8tlbAOJObkADkdqAdecH5mVbONm9blHYjI7LigJOHV5Wsju2DV4oEvrWiFZ heZilB0Ieju+orJ672WUhKSSB/tckkrcINmxQYB9PTftYR2zEvneY1lTo8KfsOi/2ZW8b3J9bNz e8KhWWPMPvU3farAKXYkUzi5SzLAnPymCwG0/CtC6jC6Qx/G+y6PhXziPzEvc3sS37oCz5lB8xw tQNKl3qBqvVm211z9VIIVZpkMj6yWQN6BDGW8qkfh/Cv2X6w8KFX0mAanL33yvj4OSNZLnwDg85 5wfyzKNUHD+YTeuWO9eyjoHkZ3tJaik+++FsnzYS0n4UWgZ5ojrl3kn6G1g85alqRYz1m9gmgQr ySi+ubgwBOsKOoUGnvzveKmvFL4VvWtRBndjmiwID4wMF6NmdwlGWigR9G9wJEDWg2L8vT5niu5 diJ4aXtZ2omUg== X-Received: by 2002:a05:6870:9e83:b0:43d:5d22:4719 with SMTP id 586e51a60fabf-44cab961fa0mr69097fac.22.1782886195152; Tue, 30 Jun 2026 23:09:55 -0700 (PDT) Received: from localhost ([2a03:2880:10ff::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44c62027e5esm886593fac.9.2026.06.30.23.09.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 23:09:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-integrity@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 30 Jun 2026 23:09:52 -0700 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Jiri Olsa" , "Kumar Kartikeya Dwivedi" , "Emil Tsalapatis" , "Matt Bobrowski" , "James Morris" , "Serge E . Hallyn" , "Casey Schaufler" , "Stephen Smalley" , "Ondrej Mosnacek" , "Mimi Zohar" , "Roberto Sassu" , "Dmitry Kasatkin" , "Eric Snowberg" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Shuah Khan" , , , , , , , Subject: Re: [PATCH v4 bpf-next 2/3] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling From: "Alexei Starovoitov" To: "Paul Moore" , "David Windsor" X-Mailer: aerc References: <20260630183956.281293-1-dwindsor@gmail.com> <20260630183956.281293-3-dwindsor@gmail.com> In-Reply-To: On Tue Jun 30, 2026 at 12:20 PM PDT, Paul Moore wrote: >> +__bpf_kfunc int bpf_init_inode_xattr(struct lsm_xattrs *xattrs, >> + const char *name__str, >> + const struct bpf_dynptr *value_p) >> +{ >> + struct bpf_dynptr_kern *value_ptr =3D (struct bpf_dynptr_kern *)= value_p; >> + size_t name_len; >> + void *xattr_value; >> + struct xattr *xattr; >> + const void *value; >> + u32 value_len; >> + >> + if (!xattrs || !xattrs->xattrs || !name__str) >> + return -EINVAL; >> + if (bpf_xattrs_used(xattrs) >=3D BPF_LSM_INODE_INIT_XATTRS) >> + return -ENOSPC; >> + >> + name_len =3D strlen(name__str); >> + if (name_len =3D=3D 0 || name_len > XATTR_NAME_MAX) >> + return -EINVAL; >> + if (strncmp(name__str, XATTR_BPF_LSM_SUFFIX, >> + sizeof(XATTR_BPF_LSM_SUFFIX) - 1)) >> + return -EPERM; >> + >> + value_len =3D __bpf_dynptr_size(value_ptr); >> + if (value_len =3D=3D 0 || value_len > XATTR_SIZE_MAX) >> + return -EINVAL; >> + >> + value =3D __bpf_dynptr_data(value_ptr, value_len); >> + if (!value) >> + return -EINVAL; >> + >> + /* Combine xattr value + name into one allocation. */ >> + xattr_value =3D kmalloc(value_len + name_len + 1, GFP_NOFS); >> + if (!xattr_value) >> + return -ENOMEM; >> + >> + memcpy(xattr_value, value, value_len); >> + memcpy(xattr_value + value_len, name__str, name_len); >> + ((char *)xattr_value)[value_len + name_len] =3D '\0'; >> + >> + xattr =3D lsm_get_xattr_slot(xattrs); >> + if (!xattr) { >> + kfree(xattr_value); >> + return -ENOSPC; >> + } >> + >> + xattr->value =3D xattr_value; >> + xattr->name =3D (const char *)xattr_value + value_len; >> + xattr->value_len =3D value_len; >> + >> + return 0; >> +} > > This is not a generic VFS function, it is a LSM specific function, it > belongs under security/, please move the code as discussed previously. Paul, Not quite. It's all about xattrs. Having "struct lsm_xattrs" in the arguments doesn't make it lsm related. You needs to study existing kfuncs and tracepoints. A bunch of them have "*lsm*" in the arguments. All, CI found issues, so this set needs another respin. After that it's hopefully good to go. David, you're on the right track. The patchset is getting close. Thank you for working on it.