From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "Paul Moore" <paul@paul-moore.com>
Cc: "David Windsor" <dwindsor@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>, "Jiri Olsa" <jolsa@kernel.org>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Matt Bobrowski" <mattbobrowski@google.com>,
"James Morris" <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Stephen Smalley" <stephen.smalley.work@gmail.com>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
"Eric Snowberg" <eric.snowberg@oracle.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Shuah Khan" <shuah@kernel.org>,
<bpf@vger.kernel.org>, <linux-security-module@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
<linux-integrity@vger.kernel.org>, <selinux@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 bpf-next 3/4] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling
Date: Fri, 31 Jul 2026 20:50:43 +0200 [thread overview]
Message-ID: <DKCZDM2G8VHO.38SPG4I4JZTJI@gmail.com> (raw)
In-Reply-To: <CAHC9VhRK38bVU5+rYxwLsvVt0oBBSWs4xKsjexbvc3TuA9LVNQ@mail.gmail.com>
On Fri Jul 31, 2026 at 8:42 PM CEST, Paul Moore wrote:
> On Fri, Jul 31, 2026 at 2:18 PM Kumar Kartikeya Dwivedi
> <memxor@gmail.com> wrote:
>> On Fri Jul 31, 2026 at 6:59 PM CEST, Paul Moore wrote:
>> > On Fri, Jul 31, 2026 at 12:32 PM Kumar Kartikeya Dwivedi
>> > <memxor@gmail.com> wrote:
>> >> On Fri Jul 31, 2026 at 6:02 PM CEST, Paul Moore wrote:
>> >> > On Fri, Jul 31, 2026 at 11:44 AM Kumar Kartikeya Dwivedi
>> >> > <memxor@gmail.com> wrote:
>> >> >> On Fri Jul 31, 2026 at 5:30 PM CEST, David Windsor wrote:
>> >> >> > On Fri, Jul 31, 2026 at 11:17 AM Paul Moore <paul@paul-moore.com> wrote:
>
> ...
>
>> Yes, I understand you feel it should be placed under security/. You are entitled
>> to your opinion.
>>
>> No, I do not think the newly added kfunc is a big enough layering violation such
>> that we need to do it ASAP, disregarding everything else outlined above. I am
>> sure you see that too. There are several other instances of similar kfuncs.
>>
>> Therefore, please attempt to meet me halfway here.
>
> I'm happy to work with you, and/or anyone else, who wants to work on
> finding a way to test kfuncs that live in security/bpf_lsm_kfuncs.c.
Right, and for that file to exist, you need to get everyone (FS, BPF folks) to
agree on whether placing all such kfuncs there makes sense. It is not for both
of us to decide on our own. So let's revisit this whole topic once you've done
that exercise.
next prev parent reply other threads:[~2026-07-31 18:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 23:45 [PATCH v6 bpf-next 0/4] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling David Windsor
2026-07-30 23:45 ` [PATCH v6 bpf-next 1/4] security: introduce struct lsm_xattrs David Windsor
2026-07-31 22:12 ` bot+bpf-ci
2026-07-30 23:45 ` [PATCH v6 bpf-next 2/4] security: add security_lsmxattr_add() David Windsor
2026-07-30 23:45 ` [PATCH v6 bpf-next 3/4] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling David Windsor
2026-07-30 23:53 ` Paul Moore
2026-07-31 0:01 ` David Windsor
2026-07-31 15:17 ` Paul Moore
2026-07-31 15:30 ` David Windsor
2026-07-31 15:33 ` Paul Moore
2026-07-31 15:36 ` David Windsor
2026-07-31 15:44 ` Kumar Kartikeya Dwivedi
2026-07-31 16:02 ` Paul Moore
2026-07-31 16:32 ` Kumar Kartikeya Dwivedi
2026-07-31 16:59 ` Paul Moore
2026-07-31 18:18 ` Kumar Kartikeya Dwivedi
2026-07-31 18:42 ` Paul Moore
2026-07-31 18:50 ` Kumar Kartikeya Dwivedi [this message]
2026-07-31 19:05 ` Paul Moore
2026-07-31 19:20 ` Kumar Kartikeya Dwivedi
2026-07-31 20:01 ` Paul Moore
2026-07-31 20:07 ` Paul Moore
2026-07-31 20:16 ` Kumar Kartikeya Dwivedi
2026-07-31 20:48 ` Paul Moore
2026-07-31 21:29 ` Kumar Kartikeya Dwivedi
2026-07-31 21:49 ` Paul Moore
2026-07-31 22:04 ` Kumar Kartikeya Dwivedi
2026-07-31 22:23 ` Paul Moore
2026-07-31 23:11 ` David Windsor
2026-07-31 23:34 ` Kumar Kartikeya Dwivedi
2026-07-31 23:35 ` Kumar Kartikeya Dwivedi
2026-07-31 22:27 ` Casey Schaufler
2026-07-31 22:45 ` Kumar Kartikeya Dwivedi
2026-07-31 23:01 ` Casey Schaufler
2026-07-31 23:14 ` Kumar Kartikeya Dwivedi
2026-07-31 22:27 ` bot+bpf-ci
2026-07-30 23:45 ` [PATCH v6 bpf-next 4/4] selftests/bpf: add tests for bpf_init_inode_xattr kfunc David Windsor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKCZDM2G8VHO.38SPG4I4JZTJI@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=daniel@iogearbox.net \
--cc=dmitry.kasatkin@gmail.com \
--cc=dwindsor@gmail.com \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=eric.snowberg@oracle.com \
--cc=jack@suse.cz \
--cc=jmorris@namei.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yonghong.song@linux.dev \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox