From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795C7C636D7 for ; Fri, 17 Feb 2023 21:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbjBQVvQ (ORCPT ); Fri, 17 Feb 2023 16:51:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbjBQVvO (ORCPT ); Fri, 17 Feb 2023 16:51:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B184A1E5; Fri, 17 Feb 2023 13:51:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4082B82E20; Fri, 17 Feb 2023 21:51:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69BABC433D2; Fri, 17 Feb 2023 21:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676670670; bh=Zdc2juHFxUSJ+qe/tfeNLynwKrd3JRGjk7XKv1VCm8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AqqlbZLuNM1RqNqZJptZeQW/rqaZrT5D8VSMq5ZSjTU/E5r1TQKRF7PkbIVLcUH/2 8cuRUeicsGNcl8XEw5qTuFKAYIKb504ce9jGALV1RS+4ve04PmknJvlZ5fUXEzr8h7 aqUEvF6eURlnfPKkGRoQn1sUCX6U6NJMiQnQPaZiA24sK7zKdtp9yGcb5xNpRaF4OW TDNvXz2AsJ5E2vg5D1EDuiCqf1FB2wo6sF7fiI+ebz78n4/15uAI3hee6Oxm7YwEak zpQOMPBNUqcJtQOH32Y66S0vhBxpXKlezsJob1oVeSMV6BodOu3aK3TvIwIBgHiEmQ TwxcC0Nk94YGA== Date: Fri, 17 Feb 2023 23:51:05 +0200 From: Jarkko Sakkinen To: Ard Biesheuvel Cc: James Bottomley , Yujie Liu , kernel test robot , linux-integrity@vger.kernel.org, oe-kbuild-all@lists.linux.dev, keyrings@vger.kernel.org Subject: Re: [PATCH v2 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code Message-ID: References: <20230124175516.5984-7-James.Bottomley@HansenPartnership.com> <202301250706.deGvd0yq-lkp@intel.com> <3109ff421139af6b0d9e66a06d8399135e546fa7.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Feb 14, 2023 at 02:54:02PM +0100, Ard Biesheuvel wrote: > On Mon, 13 Feb 2023 at 08:45, Jarkko Sakkinen wrote: > > > > On Fri, Feb 10, 2023 at 09:48:15AM -0500, James Bottomley wrote: > > > On Wed, 2023-02-08 at 04:49 +0200, Jarkko Sakkinen wrote: > > > > On Fri, Feb 03, 2023 at 02:06:48PM +0800, Yujie Liu wrote: > > > > > Hi James, > > > > > > > > > > On Wed, Jan 25, 2023 at 07:59:09AM -0500, James Bottomley wrote: > > > > > > On Wed, 2023-01-25 at 07:11 +0800, kernel test robot wrote: > > > > > > > Hi James, > > > > > > > > > > > > > > I love your patch! Perhaps something to improve: > > > > > > > > > > > > > > [auto build test WARNING on char-misc/char-misc-testing] > > > > > > > [also build test WARNING on char-misc/char-misc-next char- > > > > > > > misc/char- > > > > > > > misc-linus zohar-integrity/next-integrity linus/master v6.2-rc5 > > > > > > > next- > > > > > > > 20230124] > > > > > > > [If your patch is applied to the wrong git tree, kindly drop us > > > > > > > a > > > > > > > note. > > > > > > > And when submitting patch, we suggest to use '--base' as > > > > > > > documented > > > > > > > in > > > > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information > > > > > > > ] > > > > > > > > > > > > > > url: > > > > > > > https://github.com/intel-lab-lkp/linux/commits/James-Bottomley/tpm-move-buffer-handling-from-static-inlines-to-real-functions/20230125-020146 > > > > > > > patch link: > > > > > > > https://lore.kernel.org/r/20230124175516.5984-7-James.Bottomley%40HansenPartnership.com > > > > > > > patch subject: [PATCH v2 06/11] tpm: Add full HMAC and > > > > > > > encrypt/decrypt session handling code > > > > > > > config: arc-allyesconfig > > > > > > > ( > > > > > > > https://download.01.org/0day-ci/archive/20230125/202301250706.de > > > > > > > Gvd0 > > > > > > > yq-lkp@intel.com/config) > > > > > > > compiler: arceb-elf-gcc (GCC) 12.1.0 > > > > > > > reproduce (this is a W=1 build): > > > > > > > wget > > > > > > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > > > > > > -O ~/bin/make.cross > > > > > > > chmod +x ~/bin/make.cross > > > > > > > # > > > > > > > https://github.com/intel-lab-lkp/linux/commit/dc0fc74718b4a786aba4a954233e8ab3afdcc03c > > > > > > > git remote add linux-review > > > > > > > https://github.com/intel-lab-lkp/linux > > > > > > > git fetch --no-tags linux-review James-Bottomley/tpm- > > > > > > > move- > > > > > > > buffer-handling-from-static-inlines-to-real-functions/20230125- > > > > > > > 020146 > > > > > > > git checkout dc0fc74718b4a786aba4a954233e8ab3afdcc03c > > > > > > > # save the config file > > > > > > > mkdir build_dir && cp config build_dir/.config > > > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > > > > > > > make.cross W=1 O=build_dir ARCH=arc olddefconfig > > > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > > > > > > > make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash > > > > > > > drivers/char/tpm/ > > > > > > > > > > > > > > If you fix the issue, kindly add following tag where applicable > > > > > > > > Reported-by: kernel test robot > > > > > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > > > > > drivers/char/tpm/tpm2-sessions.c:1184:5: warning: no > > > > > > > previous > > > > > > > prototype for 'tpm2_create_null_primary' [-Wmissing-prototypes] > > > > > > > 1184 | int tpm2_create_null_primary(struct tpm_chip *chip) > > > > > > > { > > > > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > > drivers/char/tpm/tpm2-sessions.c: In function > > > > > > > 'tpm_buf_check_hmac_response': > > > > > > > > > drivers/char/tpm/tpm2-sessions.c:831:1: warning: the frame > > > > > > > > > size > > > > > > > > > of 1132 bytes is larger than 1024 bytes [-Wframe-larger- > > > > > > > > > than=] > > > > > > > 831 | } > > > > > > > | ^ > > > > > > > drivers/char/tpm/tpm2-sessions.c: In function > > > > > > > 'tpm_buf_fill_hmac_session': > > > > > > > drivers/char/tpm/tpm2-sessions.c:579:1: warning: the frame > > > > > > > size of > > > > > > > 1132 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > > > > 579 | } > > > > > > > | ^ > > > > > > > > > > > > Is this a test problem? I can't see why the code would only blow > > > > > > the > > > > > > stack on the arc architecture and not on any other ... does it > > > > > > have > > > > > > something funny with on stack crypto structures? > > > > > > > > > > This warning is controlled by the value of CONFIG_FRAME_WARN. > > > > > > > > > > For "make ARCH=arc allyesconfig", the default value is 1024, so > > > > > this frame warning shows up during the build. > > > > > > > > > > For other arch such as "make ARCH=x86_64 allyesconfig", the default > > > > > value would be 2048 and won't have this warning. > > > > > > > > > > Not sure if this is a real problem that need to be fixed, here just > > > > > providing above information for your reference. > > > > > > > > > > -- > > > > > Best Regards, > > > > > Yujie > > > > > > > > *Must* be fixed given that it is how the default value is set now. > > > > This is wrong place to reconsider. > > > > > > > > > > > > And we do not want to add functions that bloat the stack this way. > > > > > > > > Shash just needs to be allocated from heap instead of stack. > > > > > > On x86_64 the stack usage is measured at 984 bytes, so rather than > > > jumping to conclusions let's root cause why this is a problem only on > > > the arc architecture. I suspect it's something to do with the > > > alignment constraints of shash. I've also noted it shouldn't actually > > > warn on arc because the default stack warning size there should be 2048 > > > (like x86_64). > > > > Would it such a big deal to allocate shash from heap? That would > > be IMHO more robust in the end. > > > > Can we avoid shashes and sync skciphers at all? We have sha256 and AES > library routines these days, and AES in CFB mode seems like a good > candidate for a library implementation as well - it uses AES > encryption only, and is quite straight forward to implement. [0] > > The crypto API is far too clunky for synchronous operations of > algorithms that are known at compile time, and the requirement to use > scatterlists for skciphers is especially horrid. I'm cool with any solution not polluting the stack to its limits... BR, Jarkko