From: Eric Biggers <ebiggers@kernel.org>
To: Evan Green <evgreen@chromium.org>
Cc: linux-kernel@vger.kernel.org, corbet@lwn.net,
linux-integrity@vger.kernel.org, gwendal@chromium.org,
dianders@chromium.org, apronin@chromium.org,
Pavel Machek <pavel@ucw.cz>, Ben Boeckel <me@benboeckel.net>,
rjw@rjwysocki.net, jejb@linux.ibm.com,
Kees Cook <keescook@chromium.org>,
dlunev@google.com, zohar@linux.ibm.com,
Matthew Garrett <mgarrett@aurora.tech>,
jarkko@kernel.org, linux-pm@vger.kernel.org,
Matthew Garrett <mjg59@google.com>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v5 10/11] PM: hibernate: Verify the digest encryption key
Date: Sun, 13 Nov 2022 15:47:04 -0800 [thread overview]
Message-ID: <Y3GB+CXfAWnV/3qH@sol.localdomain> (raw)
In-Reply-To: <20221111151451.v5.10.I504d456c7a94ef1aaa7a2c63775ce9690c3ad7ab@changeid>
On Fri, Nov 11, 2022 at 03:16:35PM -0800, Evan Green wrote:
> We want to ensure that the key used to encrypt the digest
What is meant by "the key used to encrypt the digest"?
> was created by
> the kernel during hibernation. To do this we request that the TPM
> include information about the value of PCR 23 at the time of key
> creation in the sealed blob. On resume, we can make sure that the PCR
> information in the creation data blob (already certified by the TPM to
> be accurate) corresponds to the expected value. Since only
> the kernel can touch PCR 23, if an attacker generates a key themselves
> the value of PCR 23 will have been different, allowing us to reject the
> key and boot normally instead of resuming.
It seems that PCR 23 is already included in the authorization policy for the
key, so why is this extra part needed?
- Eric
next prev parent reply other threads:[~2022-11-13 23:47 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 23:16 [PATCH v5 00/11] Encrypted Hibernation Evan Green
2022-11-11 23:16 ` [PATCH v5 01/11] tpm: Add support for in-kernel resetting of PCRs Evan Green
2022-11-13 20:31 ` Eric Biggers
2022-11-27 16:06 ` Jarkko Sakkinen
2022-11-27 16:07 ` Jarkko Sakkinen
2022-11-11 23:16 ` [PATCH v5 02/11] tpm: Export and rename tpm2_find_and_validate_cc() Evan Green
2022-11-11 23:16 ` [PATCH v5 03/11] tpm: Allow PCR 23 to be restricted to kernel-only use Evan Green
2022-11-13 20:46 ` Eric Biggers
2022-11-14 17:11 ` James Bottomley
2022-11-27 16:33 ` Jarkko Sakkinen
2022-11-27 16:41 ` James Bottomley
2022-11-30 20:22 ` Dr. Greg
2022-11-30 21:34 ` Casey Schaufler
2022-12-02 1:10 ` Dr. Greg
2023-01-03 20:42 ` Matthew Garrett
2023-01-03 21:04 ` William Roberts
2023-01-03 21:10 ` Matthew Garrett
2023-01-14 14:55 ` James Bottomley
2023-01-14 15:11 ` William Roberts
2023-01-15 3:05 ` Matthew Garrett
2023-01-15 14:41 ` William Roberts
2023-01-17 21:26 ` James Bottomley
2023-01-21 3:29 ` Jarkko Sakkinen
2023-01-23 17:48 ` William Roberts
2023-01-24 11:51 ` Dr. Greg
2023-01-24 12:38 ` James Bottomley
2023-01-24 15:05 ` William Roberts
2023-01-26 17:21 ` Jarkko Sakkinen
2023-01-26 17:32 ` William Roberts
2023-01-26 21:30 ` Jarkko Sakkinen
2023-01-26 22:01 ` William Roberts
2023-02-07 23:20 ` Jarkko Sakkinen
2023-01-26 17:07 ` Jarkko Sakkinen
2023-01-26 17:12 ` Jarkko Sakkinen
2023-01-26 17:20 ` William Roberts
2023-01-10 16:07 ` William Roberts
2022-11-27 16:29 ` Jarkko Sakkinen
2022-11-11 23:16 ` [PATCH v5 04/11] security: keys: trusted: Include TPM2 creation data Evan Green
2022-11-13 21:20 ` Eric Biggers
2022-11-14 3:32 ` James Bottomley
2022-11-14 16:32 ` Evan Green
2022-11-14 16:56 ` James Bottomley
2022-11-14 17:43 ` Evan Green
2022-11-14 18:00 ` James Bottomley
2022-12-02 21:03 ` James Bottomley
2022-12-05 18:43 ` Evan Green
2022-11-11 23:16 ` [PATCH v5 05/11] security: keys: trusted: Allow storage of PCR values in " Evan Green
2022-11-13 22:01 ` Eric Biggers
2022-11-11 23:16 ` [PATCH v5 06/11] security: keys: trusted: Verify " Evan Green
2022-11-13 22:13 ` Eric Biggers
2022-11-11 23:16 ` [PATCH v5 07/11] PM: hibernate: Add kernel-based encryption Evan Green
2022-11-13 22:55 ` Eric Biggers
2022-11-11 23:16 ` [PATCH v5 08/11] PM: hibernate: Use TPM-backed keys to encrypt image Evan Green
2022-11-13 23:33 ` Eric Biggers
2022-11-11 23:16 ` [PATCH v5 09/11] PM: hibernate: Mix user key in encrypted hibernate Evan Green
2022-11-13 23:44 ` Eric Biggers
2022-11-11 23:16 ` [PATCH v5 10/11] PM: hibernate: Verify the digest encryption key Evan Green
2022-11-13 23:47 ` Eric Biggers [this message]
2022-11-11 23:16 ` [PATCH v5 11/11] PM: hibernate: seal the encryption key with a PCR policy Evan Green
2022-11-13 23:51 ` Eric Biggers
2022-12-07 23:54 ` [PATCH v5 00/11] Encrypted Hibernation Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3GB+CXfAWnV/3qH@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=apronin@chromium.org \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=dlunev@google.com \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=me@benboeckel.net \
--cc=mgarrett@aurora.tech \
--cc=mjg59@google.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox