From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC47C4332F for ; Mon, 28 Nov 2022 01:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbiK1BPw (ORCPT ); Sun, 27 Nov 2022 20:15:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiK1BPn (ORCPT ); Sun, 27 Nov 2022 20:15:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE317677; Sun, 27 Nov 2022 17:15:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CC7260F2D; Mon, 28 Nov 2022 01:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBF0C433C1; Mon, 28 Nov 2022 01:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669598140; bh=CalTvPg8wCdgEbLF3hG0Q+1+uznyY15QtTUtXniSO/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rVfXUSh/F6w3G4uadWMlBKnIMUy+H8TPSbkzGeC1pHV9+ZneKwdRiE4Zqih2lx5M/ M5wozer4D0TJZlKiLPlruaDSbgQZyt0nElLPQZUGlSZwP9ywrIK5lHj36amMK/w0Wf gLsaTHYYmUN0iJxzcQhX+Pw7Gwi/diWQN7/mKamtkHHiHVQk9JLMIZ5Zqr+rMNyLHP c0kxXolTTpbukxYEld/W205PTRo5ruq1vPM0pLLX3r0Y8rvPcZ6/r4rAjApr9gJrhN 2WNKZAvUHl6qUsLhlJchQgeUCplOZQDxHfHt41rh7chCNhvuZ/2s94X8oKhO8rmoSx MtOoye/9jFW6w== Date: Mon, 28 Nov 2022 03:15:36 +0200 From: Jarkko Sakkinen To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Peter Huewe , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 003/606] tpm: tpm_i2c_infineon: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-4-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-4-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, Nov 18, 2022 at 11:35:37PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > drivers/char/tpm/tpm_i2c_infineon.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c > index fd3c3661e646..7cdaff52a96d 100644 > --- a/drivers/char/tpm/tpm_i2c_infineon.c > +++ b/drivers/char/tpm/tpm_i2c_infineon.c > @@ -681,8 +681,7 @@ MODULE_DEVICE_TABLE(of, tpm_tis_i2c_of_match); > > static SIMPLE_DEV_PM_OPS(tpm_tis_i2c_ops, tpm_pm_suspend, tpm_pm_resume); > > -static int tpm_tis_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int tpm_tis_i2c_probe(struct i2c_client *client) > { > int rc; > struct device *dev = &(client->dev); > @@ -717,7 +716,7 @@ static void tpm_tis_i2c_remove(struct i2c_client *client) > > static struct i2c_driver tpm_tis_i2c_driver = { > .id_table = tpm_tis_i2c_table, > - .probe = tpm_tis_i2c_probe, > + .probe_new = tpm_tis_i2c_probe, > .remove = tpm_tis_i2c_remove, > .driver = { > .name = "tpm_i2c_infineon", > -- > 2.38.1 > Acked-by: Jarkko Sakkinen BR, Jarkko