linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: "Angel Iglesias" <ang.iglesiasg@gmail.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Peter Huewe" <peterhuewe@gmx.de>,
	linux-i2c@vger.kernel.org, kernel@pengutronix.de,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 004/606] tpm: tpm_i2c_nuvoton: Convert to i2c's .probe_new()
Date: Mon, 28 Nov 2022 03:15:53 +0200	[thread overview]
Message-ID: <Y4QLyWrkTxiELkFf@kernel.org> (raw)
In-Reply-To: <20221118224540.619276-5-uwe@kleine-koenig.org>

On Fri, Nov 18, 2022 at 11:35:38PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/char/tpm/tpm_i2c_nuvoton.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c
> index 95c37350cc8e..a026e98add50 100644
> --- a/drivers/char/tpm/tpm_i2c_nuvoton.c
> +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
> @@ -522,9 +522,9 @@ static int get_vid(struct i2c_client *client, u32 *res)
>  	return 0;
>  }
>  
> -static int i2c_nuvoton_probe(struct i2c_client *client,
> -			     const struct i2c_device_id *id)
> +static int i2c_nuvoton_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	int rc;
>  	struct tpm_chip *chip;
>  	struct device *dev = &client->dev;
> @@ -650,7 +650,7 @@ static SIMPLE_DEV_PM_OPS(i2c_nuvoton_pm_ops, tpm_pm_suspend, tpm_pm_resume);
>  
>  static struct i2c_driver i2c_nuvoton_driver = {
>  	.id_table = i2c_nuvoton_id,
> -	.probe = i2c_nuvoton_probe,
> +	.probe_new = i2c_nuvoton_probe,
>  	.remove = i2c_nuvoton_remove,
>  	.driver = {
>  		.name = "tpm_i2c_nuvoton",
> -- 
> 2.38.1
> 

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

  reply	other threads:[~2022-11-28  1:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:35 ` [PATCH 001/606] tpm: st33zp24: Convert to Convert to i2c's .probe_new() Uwe Kleine-König
2022-11-28  1:14   ` Jarkko Sakkinen
2022-12-16  9:09   ` Uwe Kleine-König
2022-12-30 23:54     ` Jarkko Sakkinen
2023-01-06 17:56       ` Uwe Kleine-König
2023-01-20 22:00         ` Jarkko Sakkinen
2022-11-18 22:35 ` [PATCH 002/606] tpm: tpm_i2c_atmel: " Uwe Kleine-König
2022-11-28  1:15   ` Jarkko Sakkinen
2022-11-18 22:35 ` [PATCH 003/606] tpm: tpm_i2c_infineon: " Uwe Kleine-König
2022-11-28  1:15   ` Jarkko Sakkinen
2022-11-18 22:35 ` [PATCH 004/606] tpm: tpm_i2c_nuvoton: " Uwe Kleine-König
2022-11-28  1:15   ` Jarkko Sakkinen [this message]
2022-11-18 22:35 ` [PATCH 005/606] tpm: tis_i2c: " Uwe Kleine-König
2022-11-28  1:16   ` Jarkko Sakkinen
2022-11-19  6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
2022-11-19  6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
2022-11-21  9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16   ` Uwe Kleine-König
2022-11-26 15:43     ` Andy Shevchenko
2022-12-09 12:00 ` (subset) " Robert Foss
2022-12-12 16:36 ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4QLyWrkTxiELkFf@kernel.org \
    --to=jarkko@kernel.org \
    --cc=ang.iglesiasg@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=jgg@ziepe.ca \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=uwe@kleine-koenig.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).