From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
Vitaly Chikunov <vt@altlinux.org>,
Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH ima-evm-utils] ci: cleanup build.sh test log output
Date: Thu, 26 Jan 2023 00:00:46 +0100 [thread overview]
Message-ID: <Y9G0nhYZmqsW2PUd@pevik> (raw)
In-Reply-To: <20230125221311.395032-1-zohar@linux.ibm.com>
Hi Mimi,
> Unlike the original ima-evm-utils ima_hash.test and sign_verify.test
> selftests, kernel tests may fail for any number of reasons (e.g. kernel
> config, permissions, missing applications, test infrastructure). For
> these tests, the full test log is needed to analyze the failure.
> Create a phony target in tests/Makefile.am named "check-logs". Based on
> test name, output different amounts of the test log.
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
prev parent reply other threads:[~2023-01-25 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 22:13 [PATCH ima-evm-utils] ci: cleanup build.sh test log output Mimi Zohar
2023-01-25 23:00 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9G0nhYZmqsW2PUd@pevik \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=roberto.sassu@huaweicloud.com \
--cc=stefanb@linux.ibm.com \
--cc=vt@altlinux.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox