From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2ECAC433E0 for ; Tue, 2 Feb 2021 15:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F83464E9A for ; Tue, 2 Feb 2021 15:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233290AbhBBPhc (ORCPT ); Tue, 2 Feb 2021 10:37:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:44240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235555AbhBBPe3 (ORCPT ); Tue, 2 Feb 2021 10:34:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B7D864E92; Tue, 2 Feb 2021 15:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612280028; bh=T3DVUO/GgGfi86E/fUEjepr1D9Sby+jHPBoOfChLKkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHbAAO/01CxQRjzrZuDMHZUN0rn6FkGXUoJ3Qv21irQdNM94ukiy6Ohqgqfdfcpgc mIFM+ed4gFJkkH09s3XMDqUqa0x2mSDs3NcJi7tBnIAgEvHgJ5IXPhlLniK2w3RZaL mRNuU4RmTOTvnuDjo1K0DRYEZtVPuqy0VpqPr2FyfLh4eqlQUNHj488ivreNy9d6dY eA3C1+5cFVmRzllY6+3YPQiWXwZR5oIe14O8yyLaoK4ms/S9q8NV9BiybHyzwIZDs5 2DjgVa2NqWUh9TkNfYI5LK3KPWo7tgzk6Zwe2HxO4k3bZGh3fbIE/JQz1U8qofPhC1 R4FMTr+kppAoQ== Date: Tue, 2 Feb 2021 17:33:41 +0200 From: Jarkko Sakkinen To: Guenter Roeck Cc: =?utf-8?Q?=C5=81ukasz?= Majczak , Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin , James.Bottomley@hansenpartnership.com Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls Message-ID: References: <20210123014247.989368-1-lma@semihalf.com> <20210125171846.GA31929@roeck-us.net> <7a702108-ec9e-b2e2-be89-3590437c0eb5@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a702108-ec9e-b2e2-be89-3590437c0eb5@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Sat, Jan 30, 2021 at 03:49:09PM -0800, Guenter Roeck wrote: > On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > >> Hi Jarkko, Guenter > >> > >> Yes, here are the logs when failure occurs - > >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > >> Look for a phrase "TPM returned invalid status" > >> > >> Guenter - good suggestion - I will try to keep it as tight as possible. > >> > >> Best regards, > >> Lukasz > > > > Is it possible for you try out with linux-next? Thanks. It's a known > > issue, which ought to be fixed by now. > > > > The log message is harmless, it'a warning not panic, and does not > > endanger system stability. WARN()'s always dump stack trace. No oops > > is happening. > > > > There is a note in the kernel documentation which states: > > Note that the WARN()-family should only be used for "expected to > be unreachable" situations. If you want to warn about "reachable > but undesirable" situations, please use the pr_warn()-family of > functions. > > It seems to me that "harmless" doesn't really fit the expected > use of WARN(). Should it possibly be converted to pr_warn() ? It should, and I agree that it was a mistake to merge the commit that added this WARN(). I'm sending a late PR to Linus containing just the James' fixes. I'll include one line change to that PR, that does just what you suggested. It also lacks useful information, i.e. the status. I just send a fixed with your "suggested-by". Can you review and ack it ASAP so that I can then go on and send PR to Linus? /Jarkko