From: Jarkko Sakkinen <jarkko@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: David Howells <dhowells@redhat.com>,
linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v15 3/5] security: keys: trusted: fix TPM2 authorizations
Date: Fri, 12 Feb 2021 13:55:28 +0200 [thread overview]
Message-ID: <YCZssKIEGFML+4Br@kernel.org> (raw)
In-Reply-To: <781858e64422e78d0285c6762470a3ef3b6a114d.camel@HansenPartnership.com>
On Wed, Feb 10, 2021 at 08:12:19AM -0800, James Bottomley wrote:
> On Wed, 2021-02-10 at 15:58 +0000, David Howells wrote:
> > James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> >
> > > keyctl add trusted kmk "new 32
> > > blobauth=f572d396fae9206628714fb2ce00f72e94f2258fkeyhandle=81000001
> > > " @u
> >
> > I presume there should be a space in there?
>
> Um, yes. My screen wraps at 80 characters which has keyhandle=
> conveniently on the next line.
>
> James
Please send a new revision. There was already two checkpatch errors I had
to fix manually and also found 3rd issue when working with Sumit's patches:
trusted-y += trusted_tpm2.o tpm2key.asn1.o
Please line these up like
trusted-y += trusted_tpm2.o
trusted-y += tpm2key.asn1.o
Is coherent with the line adding trusted_tpm1.o, and makes merging new
features easier (e.g. TEE).
I dropped current patches.
/Jarkko
next prev parent reply other threads:[~2021-02-12 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 19:06 [PATCH v15 0/5] TPM 2.0 trusted key rework James Bottomley
2021-01-27 19:06 ` [PATCH v15 1/5] lib: add ASN.1 encoder James Bottomley
2021-01-27 19:06 ` [PATCH v15 2/5] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2021-01-27 19:06 ` [PATCH v15 3/5] security: keys: trusted: fix TPM2 authorizations James Bottomley
2021-01-27 19:06 ` [PATCH v15 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2021-01-30 16:29 ` Jarkko Sakkinen
2021-01-30 17:12 ` James Bottomley
2021-01-27 19:06 ` [PATCH v15 5/5] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2021-01-28 6:00 ` [PATCH v15 0/5] TPM 2.0 trusted key rework Jarkko Sakkinen
2021-02-10 15:58 ` [PATCH v15 3/5] security: keys: trusted: fix TPM2 authorizations David Howells
2021-02-10 16:12 ` James Bottomley
2021-02-12 11:55 ` Jarkko Sakkinen [this message]
2021-02-19 18:24 ` [PATCH v15 0/5] TPM 2.0 trusted key rework Jarkko Sakkinen
2021-02-19 18:35 ` James Bottomley
2021-02-20 2:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCZssKIEGFML+4Br@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).