From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A70C433E0 for ; Fri, 12 Feb 2021 23:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FCCC64E26 for ; Fri, 12 Feb 2021 23:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbhBLXq6 (ORCPT ); Fri, 12 Feb 2021 18:46:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:51902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhBLXq6 (ORCPT ); Fri, 12 Feb 2021 18:46:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5A25F64D9A; Fri, 12 Feb 2021 23:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613173577; bh=A+JkqwrwmUynFKQPXSuQrAHNjKCgXWo26xLnZdfjpW0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fEkKEgQ+mt54ZAE87wJdaroWrXKLx0jd4QhaUHaUFE/HeJNb21uSAq7laCUbq9f37 Al0BlwPDZECpzRFgumKMZWDxU7w4i+4a3pz11pHgiVaAVx1Elfh6n8BH02/bfm4R1R evI9gYSA8Qv1eh5Znh4l0aQ7JPR4HhUKSzc4J9vU8pXFb5TizxjfE5KgAsk8ZsD1XK 8I29hbb8ueuduKQSfRWtag1t7/1ekJh79GL0B/Tw0HF5S5h+2ItAidn38PJQkEgaYI fWKwlX16wGrSMND4OvH7xM1WTG2wrXgCJIXofXKw1DOnxWW8h0y3qKJRUHYNXhg3e0 TH05UIVGmeRKg== Date: Sat, 13 Feb 2021 01:46:08 +0200 From: Jarkko Sakkinen To: "florian.manoel@siemens.com" , apronin@chromium.org Cc: "linux-integrity@vger.kernel.org" , "Fuchs, Andreas" , "Peter.Huewe@infineon.com" , "joshz@google.com" Subject: Re: TPM V2: kernel panic on linux reboot Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, Feb 12, 2021 at 07:20:02AM +0000, florian.manoel@siemens.com wrote: > Hi, > > => Last update and happy end > > To remember what the issue was : kernel panic on reboot on a custom board equipped with CPU NXP LS1043a and TMP V2.0 Infineon slb9670 (spi interface). > What we did but didn't fix the issue : update our kernel to 5.10.8 => panic still occurs > What we did and fix the issue => use this patch : https://lkml.org/lkml/2020/7/9/1242 Andrey, I re-read the thread, and it's been a while and I'm not sure if I fully get my old review comments. Your commit message refers to these commits: A. b4c6230bb0ba spi: Fix controller unregister order B. f40913d2dca1 spi: pxa2xx: Fix controller unregister order So I presume that either A or B causes this sequence to trigger: 1. tpm_class_shutdown() 2. tpm_del_char_device() ... and either A or B causes this sequence to trigger: 1. tpm_class_shutdown() 2. tpm_del_char_device() So: - Does that fix bundle two separate bug fixes, and if yes, which on is associated with which? - Why do they cause the sequences to trigger, and why these sequences did not trigger before? /Jarkko