* [PATCH] IMA: Fix error in comment
@ 2021-03-30 6:08 Ricardo Ribalda
2021-03-31 2:54 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda @ 2021-03-30 6:08 UTC (permalink / raw)
To: linux-integrity, linux-kernel, trivial; +Cc: Ricardo Ribalda
ima_file_mprotect does not return EACCES but EPERM.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
security/integrity/ima/ima_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9ef748ea829f..716ea29cf897 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -409,7 +409,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
* this point. Eliminate this integrity gap by denying the mprotect
* PROT_EXECUTE change, if an mmap appraise policy rule exists.
*
- * On mprotect change success, return 0. On failure, return -EACESS.
+ * On mprotect change success, return 0. On failure, return -EPERM.
*/
int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
{
--
2.31.0.291.g576ba9dcdaf-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IMA: Fix error in comment
2021-03-30 6:08 [PATCH] IMA: Fix error in comment Ricardo Ribalda
@ 2021-03-31 2:54 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2021-03-31 2:54 UTC (permalink / raw)
To: Ricardo Ribalda; +Cc: linux-integrity, linux-kernel, trivial
On Tue, Mar 30, 2021 at 08:08:45AM +0200, Ricardo Ribalda wrote:
> ima_file_mprotect does not return EACCES but EPERM.
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
> ---
> security/integrity/ima/ima_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9ef748ea829f..716ea29cf897 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -409,7 +409,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
> * this point. Eliminate this integrity gap by denying the mprotect
> * PROT_EXECUTE change, if an mmap appraise policy rule exists.
> *
> - * On mprotect change success, return 0. On failure, return -EACESS.
> + * On mprotect change success, return 0. On failure, return -EPERM.
> */
> int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
> {
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-30 6:08 [PATCH] IMA: Fix error in comment Ricardo Ribalda
2021-03-31 2:54 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).