From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFE0C433DB for ; Wed, 31 Mar 2021 02:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6299E619D7 for ; Wed, 31 Mar 2021 02:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhCaCyj (ORCPT ); Tue, 30 Mar 2021 22:54:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:34162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbhCaCyL (ORCPT ); Tue, 30 Mar 2021 22:54:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E31CC619CD; Wed, 31 Mar 2021 02:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617159249; bh=44BOhixTrsTOXN2vKxGGhWkzp//5d88yNw459tV6lEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gFoqu+lPSk8p+rInWNrYAXDlaoY79qnvR7MJZnsZ2Y5aB03QrpFvwYvOLsahLBSxw MzAz5UrG1R7r6fVIptCHBNbU/h4AlM2nglOogOZrYxU9YGTTYfmB8U1tUIUgQyr32d mRa4PYgzPkGZJFCAZVokepRoleAsy3mn9B/u6O0kBmGwqOJrcuwJEPTBY9pTZj5Jdz 9c/h4yEVqR0gotEJVUgBqVFJPIsxzZtfivdCljRzfRyqCxJ/jZdIAoFLgcJX3lfnNg ic4MsWd6Za2gbsHbMs/P+GYzJanNeE1dZdr0d6R5hnSkJiQZXwhAInbuk7i+ZrLpuD wIVFbIhAFOqnw== Date: Wed, 31 Mar 2021 05:54:06 +0300 From: Jarkko Sakkinen To: Ricardo Ribalda Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] IMA: Fix error in comment Message-ID: References: <20210330060845.18422-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330060845.18422-1-ribalda@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Mar 30, 2021 at 08:08:45AM +0200, Ricardo Ribalda wrote: > ima_file_mprotect does not return EACCES but EPERM. > > Signed-off-by: Ricardo Ribalda Acked-by: Jarkko Sakkinen /Jarkko > --- > security/integrity/ima/ima_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c > index 9ef748ea829f..716ea29cf897 100644 > --- a/security/integrity/ima/ima_main.c > +++ b/security/integrity/ima/ima_main.c > @@ -409,7 +409,7 @@ int ima_file_mmap(struct file *file, unsigned long prot) > * this point. Eliminate this integrity gap by denying the mprotect > * PROT_EXECUTE change, if an mmap appraise policy rule exists. > * > - * On mprotect change success, return 0. On failure, return -EACESS. > + * On mprotect change success, return 0. On failure, return -EPERM. > */ > int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot) > { > -- > 2.31.0.291.g576ba9dcdaf-goog > >