Re: [PATCH] spi: bcm2835: do not unregister controller in shutdown handler

Florian Fainelli
2021-10-04T17:44:40Z

On 10/4/21 10:27 AM, Mark Brown wrote:
> On Mon, Oct 04, 2021 at 02:13:01PM -0300, Jason Gunthorpe wrote:
>
>> I'm kind of surprised a scheme like this didn't involve a FW call
>> after Linux is done with the CPUs to quiet all the HW and let it
>> sleep, I've built things that way before at least.
>
> That's a *lot* of code to put in firmware if you can't physically power
> most of the system down.

Indeed, and that also assume it may be possible for firmware to have the
last say, which is not necessarily possible (though that ought to be a
system design issue that would need fixing). It seems reasonable to me
to delegate the powering off of the hardware to the respective Linux
drivers since they ought to be in the best position to make appropriate
decisions for the hardware they control.

Anyway, we are divergin slightly here, how do we go about fixing
.shutdown here?
--
Florian