Re: [PATCH 1/4] fs-verity: define a function to return the integrity protected file digest

Eric Biggers
2021-11-30T06:30:23Z

On Mon, Nov 29, 2021 at 09:33:29PM -0800, Lakshmi Ramasubramanian wrote:
> > > +/**
> > > + * fsverity_measure() - get a verity file's digest
> nit: The function name seems to suggest it is measuring the fs-verity file's
> digest. Since it is reading the file's digest: fsverity_read_digest() or
> fsverity_read_measure()?

I suggest fsverity_get_digest(). "read" is misleading because it's not being
read from disk.

- Eric