* Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")?
@ 2022-02-23 13:50 Lukas Bulwahn
2022-02-23 15:49 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2022-02-23 13:50 UTC (permalink / raw)
To: Mickaël Salaün, Jarkko Sakkinen,
open list:ASYMMETRIC KEYS, linux-crypto, linux-integrity,
Linux Kernel Mailing List
Dear Jarkko, dear Mickaël,
The commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes
are valid") adds a file entry for scripts/extract-cert.c in the
CERTIFICATE HANDLING section in MAINTAINERS.
Hence, ./scripts/get_maintainers.pl --self-test=patterns complains:
warning: no file matches F: scripts/extract-cert.c
I could not see that line being added in the original patch, i.e.,
https://lore.kernel.org/all/20210712170313.884724-3-mic@digikod.net/,
but it was only part of the context of that patch. In linux-next, it
appears to be part of the commit above.
That seems to be introduced while applying or rebasing the patch to
some later version. If that is the case, you can probably just drop
this line "F: scripts/extract-cert.c" in the MAINTAINERS file.
Best regards,
Lukas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")?
2022-02-23 13:50 Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")? Lukas Bulwahn
@ 2022-02-23 15:49 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2022-02-23 15:49 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Mickaël Salaün, open list:ASYMMETRIC KEYS, linux-crypto,
linux-integrity, Linux Kernel Mailing List
On Wed, Feb 23, 2022 at 02:50:42PM +0100, Lukas Bulwahn wrote:
> Dear Jarkko, dear Mickaël,
>
> The commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes
> are valid") adds a file entry for scripts/extract-cert.c in the
> CERTIFICATE HANDLING section in MAINTAINERS.
>
> Hence, ./scripts/get_maintainers.pl --self-test=patterns complains:
>
> warning: no file matches F: scripts/extract-cert.c
>
> I could not see that line being added in the original patch, i.e.,
> https://lore.kernel.org/all/20210712170313.884724-3-mic@digikod.net/,
> but it was only part of the context of that patch. In linux-next, it
> appears to be part of the commit above.
>
> That seems to be introduced while applying or rebasing the patch to
> some later version. If that is the case, you can probably just drop
> this line "F: scripts/extract-cert.c" in the MAINTAINERS file.
Thank you, I removed the entry. I had to solve a merge conflict with
this patch, and made a human error.
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-23 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-23 13:50 Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")? Lukas Bulwahn
2022-02-23 15:49 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).