From: Jarkko Sakkinen <jarkko@kernel.org>
To: Haowen Bai <baihaowen@meizu.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool functions
Date: Sun, 20 Mar 2022 23:13:31 +0200 [thread overview]
Message-ID: <YjeY+7CI6n7gUdVX@kernel.org> (raw)
In-Reply-To: <1647574525-25152-1-git-send-email-baihaowen@meizu.com>
On Fri, Mar 18, 2022 at 11:35:25AM +0800, Haowen Bai wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/char/tpm/tpm_ftpm_tee.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 6e32355..5c23342 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -177,7 +177,7 @@ static u8 ftpm_tee_tpm_op_status(struct tpm_chip *chip)
>
> static bool ftpm_tee_tpm_req_canceled(struct tpm_chip *chip, u8 status)
> {
> - return 0;
> + return false;
> }
>
> static const struct tpm_class_ops ftpm_tee_tpm_ops = {
> --
> 2.7.4
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2022-03-20 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 3:35 [PATCH] tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool functions Haowen Bai
2022-03-20 21:13 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjeY+7CI6n7gUdVX@kernel.org \
--to=jarkko@kernel.org \
--cc=baihaowen@meizu.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).