From: Eric Biggers <ebiggers@kernel.org>
To: Jes Klinke <jbk@google.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, linux-integrity@vger.kernel.org
Subject: Re: PATCH: Google security chip, additional DID:VID
Date: Mon, 4 Apr 2022 16:21:42 -0700 [thread overview]
Message-ID: <Ykt9hoX+mPG1oirv@sol.localdomain> (raw)
In-Reply-To: <CANMTAZSQgokaG7ZaqipcR56yzOK7iDq50P0_GKd-H7nxUX3TzQ@mail.gmail.com>
On Mon, Apr 04, 2022 at 04:00:31PM -0700, Jes Klinke wrote:
> Hello Peter,
>
> I am a firmware engineer working on the TPM chip in Chromebooks (known
> as cr50). As we plan to deploy a new codebase on our TPM chips, we
> will have them present a new DID:VID value, but otherwise follow the
> same protocol as the existing implementations.
>
> The below patch has the effect of accepting one additional numerical
> value, and logging one of two messages, depending on the value.
> Unfortunately, I had to reverse the indentation, so the diff appears
> to touch more lines than it needed to do.
>
> I am unsure which procedure to follow, as this is my first kernel
> patch. Let me know if posting the patch inline like this is not the
> way to go.
Can you take a look at Documentation/process/submitting-patches.rst?
- Eric
next prev parent reply other threads:[~2022-04-04 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 23:00 PATCH: Google security chip, additional DID:VID Jes Klinke
2022-04-04 23:21 ` Eric Biggers [this message]
2022-04-04 23:44 ` Jes Klinke
2022-04-04 23:58 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykt9hoX+mPG1oirv@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jbk@google.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox