From: Jarkko Sakkinen <jarkko@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tpm: fix platform_no_drv_owner.cocci warning
Date: Mon, 11 Jul 2022 03:02:11 +0300 [thread overview]
Message-ID: <Ystog1WaJZ5XgJAP@kernel.org> (raw)
In-Reply-To: <20220701091322.59384-1-yang.lee@linux.alibaba.com>
On Fri, Jul 01, 2022 at 05:13:22PM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/char/tpm/tpm_tis_i2c.c:379:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/char/tpm/tpm_tis_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index 8e0686fe4eb1..ba0911b1d1ff 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -376,7 +376,6 @@ MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
>
> static struct i2c_driver tpm_tis_i2c_driver = {
> .driver = {
> - .owner = THIS_MODULE,
> .name = "tpm_tis_i2c",
> .pm = &tpm_tis_pm,
> .of_match_table = of_match_ptr(of_tis_i2c_match),
> --
> 2.20.1.7.g153144c
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2022-07-11 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:13 [PATCH -next] tpm: fix platform_no_drv_owner.cocci warning Yang Li
2022-07-11 0:02 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ystog1WaJZ5XgJAP@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).