From: Eric Biggers <ebiggers@kernel.org>
To: Evan Green <evgreen@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Matthew Garrett <mgarrett@aurora.tech>,
dlunev@google.com, zohar@linux.ibm.com, jejb@linux.ibm.com,
linux-integrity@vger.kernel.org, corbet@lwn.net,
rjw@rjwysocki.net, gwendal@chromium.org, jarkko@kernel.org,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 09/10] PM: hibernate: Verify the digest encryption key
Date: Tue, 2 Aug 2022 15:51:01 -0700 [thread overview]
Message-ID: <YumqVb5RQQ5knPk7@sol.localdomain> (raw)
In-Reply-To: <20220504161439.9.I504d456c7a94ef1aaa7a2c63775ce9690c3ad7ab@changeid>
On Wed, May 04, 2022 at 04:21:01PM -0700, Evan Green wrote:
> + /* TPML_PCR_SELECTION.count */
> + if (be32_to_cpu(*(int *)payload->creation) != 1) {
> + ret = -EINVAL;
> + goto out;
> + }
Make sure to run sparse by passing C=1 to make. It will find bugs like this
where the wrong type is being used (int instead of __be32 here).
- Eric
next prev parent reply other threads:[~2022-08-02 22:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 23:20 [PATCH 00/10] Encrypted Hibernation Evan Green
2022-05-04 23:20 ` [PATCH 01/10] tpm: Add support for in-kernel resetting of PCRs Evan Green
2022-05-04 23:20 ` [PATCH 02/10] tpm: Allow PCR 23 to be restricted to kernel-only use Evan Green
2022-05-04 23:20 ` [PATCH 03/10] security: keys: trusted: Parse out individual components of the key blob Evan Green
2022-05-04 23:20 ` [PATCH 04/10] security: keys: trusted: Allow storage of PCR values in creation data Evan Green
2022-08-02 23:00 ` Eric Biggers
2022-08-03 20:48 ` Evan Green
2022-05-04 23:20 ` [PATCH 05/10] security: keys: trusted: Verify " Evan Green
2022-05-04 23:20 ` [PATCH 06/10] PM: hibernate: Add kernel-based encryption Evan Green
2022-08-29 21:45 ` TPM: hibernate with IMA PCR 10 Ken Goldman
2022-08-29 21:51 ` Matthew Garrett
2022-08-31 2:48 ` Jarkko Sakkinen
2022-09-07 20:47 ` Evan Green
2022-09-07 23:57 ` Mimi Zohar
2022-09-08 5:25 ` Jarkko Sakkinen
2022-09-11 2:40 ` Mimi Zohar
2022-09-20 4:36 ` Jarkko Sakkinen
2022-09-21 20:15 ` Mimi Zohar
2022-09-23 13:30 ` Jarkko Sakkinen
2022-09-27 16:03 ` Evan Green
2022-09-28 9:42 ` Jonathan McDowell
2022-05-04 23:20 ` [PATCH 07/10] PM: hibernate: Use TPM-backed keys to encrypt image Evan Green
2022-05-04 23:21 ` [PATCH 08/10] PM: hibernate: Mix user key in encrypted hibernate Evan Green
2022-05-06 16:08 ` Pavel Machek
2022-05-09 16:44 ` Evan Green
2022-05-10 12:29 ` Pavel Machek
2022-05-10 16:02 ` Evan Green
2022-08-02 22:48 ` Eric Biggers
2022-08-03 20:48 ` Evan Green
2022-05-04 23:21 ` [PATCH 09/10] PM: hibernate: Verify the digest encryption key Evan Green
2022-08-02 22:51 ` Eric Biggers [this message]
2022-05-04 23:21 ` [PATCH 10/10] PM: hibernate: seal the encryption key with a PCR policy Evan Green
2022-05-06 16:08 ` [PATCH 00/10] Encrypted Hibernation Pavel Machek
2022-05-09 16:43 ` Evan Green
2022-05-17 16:06 ` Rafael J. Wysocki
2022-05-17 17:34 ` Evan Green
2022-06-16 15:42 ` Evan Green
2022-08-01 22:32 ` Evan Green
2022-08-02 18:36 ` Matthew Garrett
2022-08-04 0:59 ` Jarkko Sakkinen
2022-08-04 21:55 ` Evan Green
2022-08-06 18:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YumqVb5RQQ5knPk7@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=corbet@lwn.net \
--cc=dlunev@google.com \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=len.brown@intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgarrett@aurora.tech \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox