From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jonathan McDowell <noodles@earth.li>
Cc: Michal Suchanek <msuchanek@suse.de>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: tis: Increase the default for timeouts B and C
Date: Thu, 3 Apr 2025 21:45:21 +0300 [thread overview]
Message-ID: <Z-7XQYP7_tXYR2Ik@kernel.org> (raw)
In-Reply-To: <Z-13xOebA3LvQQ-8@earth.li>
On Wed, Apr 02, 2025 at 06:45:40PM +0100, Jonathan McDowell wrote:
> On Wed, Apr 02, 2025 at 07:21:30PM +0200, Michal Suchanek wrote:
> > With some Infineon chips the timeouts in tpm_tis_send_data (both B and
> > C) can reach up to about 2250 ms.
> >
> > Extend the timeout duration to accommodate this.
>
> The problem here is the bump of timeout_c is going to interact poorly with
> the Infineon errata workaround, as now we'll wait 4s instead of 200ms to
> detect the stuck status change.
>
> (Also shouldn't timeout_c already end up as 750ms, as it's
> max(TIS_SHORT_TIMEOUT, TPM2_TIMEOUT_C), and TIS_SHORT_TIMEOUT is 750 vs 200
> for TPM2_TIMEOUT_C? That doesn't seem to be borne out by your logs, nor my
> results.)
Just noticed that the commit did not end up having fixes etc. tags:
https://web.git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=de9e33df7762abbfc2a1568291f2c3a3154c6a9d
Should we forward to stable?
BR, Jarkko
next prev parent reply other threads:[~2025-04-03 18:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 17:21 [PATCH] tpm: tis: Increase the default for timeouts B and C Michal Suchanek
2025-04-02 17:45 ` Jonathan McDowell
2025-04-02 20:07 ` Michal Suchánek
2025-04-03 9:31 ` Michal Suchánek
2025-04-03 11:00 ` Jonathan McDowell
2025-04-03 11:56 ` Michal Suchánek
2025-04-03 13:00 ` Jonathan McDowell
2025-04-03 14:11 ` Michal Suchánek
2025-04-03 18:25 ` [PATCH] tpm: tis: Increase the default for timeout B Michal Suchanek
2025-04-03 18:28 ` Paul Menzel
2025-04-04 8:23 ` [PATCH v3] tpm: tis: Double the timeout B to 4s Michal Suchanek
2025-04-04 8:53 ` Jarkko Sakkinen
2025-05-14 12:10 ` Michal Suchánek
2025-05-15 1:41 ` Jarkko Sakkinen
2025-05-15 11:17 ` Jarkko Sakkinen
2025-04-03 18:49 ` [PATCH] tpm: tis: Increase the default for timeout B Jarkko Sakkinen
2025-04-04 7:53 ` Michal Suchánek
2025-04-04 8:12 ` Michal Suchánek
2025-04-04 8:14 ` Jarkko Sakkinen
2025-04-03 18:45 ` Jarkko Sakkinen [this message]
2025-04-03 20:43 ` [PATCH] tpm: tis: Increase the default for timeouts B and C Jonathan McDowell
2025-04-04 7:51 ` Michal Suchánek
2025-04-04 8:10 ` Jarkko Sakkinen
2025-04-04 9:31 ` Jonathan McDowell
2025-04-04 11:58 ` Jarkko Sakkinen
2025-04-03 18:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-7XQYP7_tXYR2Ik@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=noodles@earth.li \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).