From: Jarkko Sakkinen <jarkko@kernel.org>
To: Ahmed Salem <x0rw3ll@gmail.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, shuah@kernel.org,
skhan@linuxfoundation.org, linux-integrity@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v3] selftests: tpm2: test_smoke: use POSIX-conformant expression operator
Date: Wed, 12 Feb 2025 01:25:20 +0200 [thread overview]
Message-ID: <Z6vcYJjC7vEpf5Um@kernel.org> (raw)
In-Reply-To: <x4dtkjgxwy7vyjg7rryvqqu3lwhiqm6jmhr4ph2fexa7m2m2mv@dbefieqhx6x6>
On Wed, Feb 12, 2025 at 01:05:02AM +0200, Ahmed Salem wrote:
> On 25/02/11 08:10PM, Jarkko Sakkinen wrote:
> > On Tue Feb 11, 2025 at 5:00 AM EET, Ahmed Salem wrote:
> > > Use POSIX-conformant operator symbol '='.
> > >
> > > Signed-off-by: Ahmed Salem <x0rw3ll@gmail.com>
> > > ---
> > >
> > > Apologies for my previous mistakes.
> > >
> > > Changes in v3:
> > > - Reword mistaken commit message
> > >
> > > Changes in v2:
> > > - Remove snippets pinpointing the issue
> > > from commit message
> >
> > OK I read what I wrote and I guess it could have been misinterpreted.
> >
> > What I meant was to take the relevant part of the transcript that shows
> > the issue (and possibly also how it works when fixed).
> >
> > Sorry about that.
> >
> > [1] https://lore.kernel.org/linux-integrity/D7OY3ZVGJOV5.R3SL9SBFT2DF@kernel.org/
> >
> > BR, Jarkko
>
> Understood. Thank you so much for your review and continued guidance!
>
> I will be sending the revised patch shortly with the proposed changes.
Yeah, like narrow down the transcript that's all, and yep what I said
was somewhat misguiding...
BR, Jarkko
prev parent reply other threads:[~2025-02-11 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 3:00 [PATCH v3] selftests: tpm2: test_smoke: use POSIX-conformant expression operator Ahmed Salem
2025-02-11 18:10 ` Jarkko Sakkinen
2025-02-11 23:05 ` Ahmed Salem
2025-02-11 23:25 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6vcYJjC7vEpf5Um@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=x0rw3ll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox