linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers
@ 2025-03-11 13:14 WangYuli
  2025-03-12  6:23 ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: WangYuli @ 2025-03-11 13:14 UTC (permalink / raw)
  To: peterhuewe, jarkko, jgg
  Cc: linux-integrity, linux-kernel, James.Bottomley, stefanb, ardb,
	roberto.sassu, viro, gourry, WangYuli

As of now, within include/linux, there are three header files
pertaining to the TPM driver: tpm.h, tpm_eventlg.h and tpm_command.h.

Upon investigation when attempting code modifications, it has become
evident that these files are currently without a maintainer.

In light of their intrinsic relationship with the TPM driver itself,
stewardship of these files should fall under the TPM subsystem. So
that scripts/get_maintainer.pl can provide more accurate output

It should be noted that this change entails the omission of some
commit_signer and author entries from the scripts/get_maintainer.pl
output. A list is provided herein for future investigation:
 *tpm.h:
    Jarkko Sakkinen <jarkko@kernel.org> (commit_signer)
    James Bottomley <James.Bottomley@HansenPartnership.com> (commit_signer)
    Stefan Berger <stefanb@linux.ibm.com> (commit_signer)
    Ard Biesheuvel <ardb@kernel.org> (commit_signer)
    Roberto Sassu <roberto.sassu@huawei.com> (commit_signer)
    Al Viro <viro@zeniv.linux.org.uk> (author)
 *tpm_eventlog.h:
    Ard Biesheuvel <ardb@kernel.org> (commit_signer)
    Gregory Price <gourry@gourry.net> (commit_signer)

In passing, also include include/uapi/linux/vtpm_proxy.h for TPM
maintainers, as it is facing a comparable plight.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ed7aa6867674..4a7b2e8b97de 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -24037,6 +24037,8 @@ Q:	https://patchwork.kernel.org/project/linux-integrity/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
 F:	Documentation/devicetree/bindings/tpm/
 F:	drivers/char/tpm/
+F:	include/linux/tpm*.h
+F:	include/uapi/linux/vtpm_proxy.h
 F:	tools/testing/selftests/tpm2/
 
 TPS546D24 DRIVER
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers
  2025-03-11 13:14 [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers WangYuli
@ 2025-03-12  6:23 ` Jarkko Sakkinen
  2025-03-12  6:48   ` WangYuli
  0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2025-03-12  6:23 UTC (permalink / raw)
  To: WangYuli
  Cc: peterhuewe, jgg, linux-integrity, linux-kernel, James.Bottomley,
	stefanb, ardb, roberto.sassu, viro, gourry

On Tue, Mar 11, 2025 at 09:14:40PM +0800, WangYuli wrote:
> As of now, within include/linux, there are three header files
> pertaining to the TPM driver: tpm.h, tpm_eventlg.h and tpm_command.h.
> 
> Upon investigation when attempting code modifications, it has become
> evident that these files are currently without a maintainer.
> 
> In light of their intrinsic relationship with the TPM driver itself,
> stewardship of these files should fall under the TPM subsystem. So
> that scripts/get_maintainer.pl can provide more accurate output

[SNIP]

> 
> In passing, also include include/uapi/linux/vtpm_proxy.h for TPM
> maintainers, as it is facing a comparable plight.
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>

"Subnames" are separated with space, not with camel case.

> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ed7aa6867674..4a7b2e8b97de 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24037,6 +24037,8 @@ Q:	https://patchwork.kernel.org/project/linux-integrity/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
>  F:	Documentation/devicetree/bindings/tpm/
>  F:	drivers/char/tpm/
> +F:	include/linux/tpm*.h
> +F:	include/uapi/linux/vtpm_proxy.h
>  F:	tools/testing/selftests/tpm2/
>  
>  TPS546D24 DRIVER
> -- 
> 2.47.2
> 

BR, Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers
  2025-03-12  6:23 ` Jarkko Sakkinen
@ 2025-03-12  6:48   ` WangYuli
  2025-03-14 15:05     ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: WangYuli @ 2025-03-12  6:48 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: peterhuewe, jgg, linux-integrity, linux-kernel, James.Bottomley,
	stefanb, ardb, roberto.sassu, viro, gourry


[-- Attachment #1.1.1: Type: text/plain, Size: 747 bytes --]

Hi Jarkko,

On 2025/3/12 14:23, Jarkko Sakkinen wrote:
> "Subnames" are separated with space, not with camel case.
>
It's just a matter of regional cultural differences.

In my country, we don't have the concept of "Subname" in names.

We only have "Surname" and "Given name", and our convention is to put 
the surname first, followed by the given name, without a space in between.

So I don't think I need to make any changes to my sign-off.

Of course, as you are the TPM maintainer, I respect your opinion, and if 
you strongly insist, I can change my sign-off but only for all future 
TPM-related commits, perhaps by using Unicode characters instead of 
spelling it out with English letters.

Thanks,

-- 

王昱力


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 645 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers
  2025-03-12  6:48   ` WangYuli
@ 2025-03-14 15:05     ` Jarkko Sakkinen
  0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2025-03-14 15:05 UTC (permalink / raw)
  To: WangYuli
  Cc: peterhuewe, jgg, linux-integrity, linux-kernel, James.Bottomley,
	stefanb, ardb, roberto.sassu, viro, gourry

On Wed, Mar 12, 2025 at 02:48:51PM +0800, WangYuli wrote:
> Hi Jarkko,
> 
> On 2025/3/12 14:23, Jarkko Sakkinen wrote:
> > "Subnames" are separated with space, not with camel case.
> > 
> It's just a matter of regional cultural differences.
> 
> In my country, we don't have the concept of "Subname" in names.
> 
> We only have "Surname" and "Given name", and our convention is to put the
> surname first, followed by the given name, without a space in between.
> 
> So I don't think I need to make any changes to my sign-off.

OK, I don't really mind the order, and I did not about the white space
part.

So with that

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>


> 
> Of course, as you are the TPM maintainer, I respect your opinion, and if you
> strongly insist, I can change my sign-off but only for all future
> TPM-related commits, perhaps by using Unicode characters instead of spelling
> it out with English letters.

It's always good to get educated, no worries.

> 
> Thanks,
> 
> -- 
> 
> 王昱力
> 


BR, Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-14 15:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-11 13:14 [PATCH] MAINTAINERS: Add include/linux/tpm*.h to TPM maintainers WangYuli
2025-03-12  6:23 ` Jarkko Sakkinen
2025-03-12  6:48   ` WangYuli
2025-03-14 15:05     ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).