Re: REGRESSION WITH BISECT: v6.5-rc6 TPM patch breaks S3 on some Intel systems

[Tyler Stachecki <stachecki.tyler@gmail.com>]

On Fri, Aug 18, 2023 at 02:39:58PM -0700, Todd Brandt wrote:
> > > > > > > > > > > > While testing S3 on 6.5.0-rc6 we've found that 5
> > > > > > > > > > > > systems are seeing
> > > > > > > > > > > > a
> > > > > > > > > > > > crash and reboot situation when S3 suspend is
> > > > > > > > > > > > initiated. To
> > > > > > > > > > > > reproduce
> > > > > > > > > > > > it, this call is all that's required "sudo
> > > > > > > > > > > > sleepgraph -m mem
> > > > > > > > > > > > -rtcwake
> > > > > > > > > > > > 15".
> > > > > > > > > > > 
> 
> I just ran 6.5.0-rc6 plus this patch on all 5 machines where the
> problem was detected and they work now. It looks good.
> 
> Tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>

I just wanted to report that at least on an SBC running a J4105, this
prevented the kernel from booting *at all* ever since 6.1.46 was released.

The fix which drops the ret assignment above allows the SBC to successfully
boot a kernel again -- just mentioning for severity given that:
  1) It also impacts the 6.1 LTS kernel that distros are tracking
  2) In some cases, the kernel no longer boots anymore at all

SBC this is seen on is a Seeed Studio ODYSSEY - X86J4105 for the curious.

Tested-by: Tyler J Stachecki <stachecki.tyler@gmail.com>