From: Lukas Wunner <lukas@wunner.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "M. Haener" <michael.haener@siemens.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding
Date: Sat, 13 Apr 2024 12:51:15 +0200 [thread overview]
Message-ID: <ZhpjozjbeWrb0OTl@wunner.de> (raw)
In-Reply-To: <889ca65c-c9c7-4658-9c34-5d89774218cc@linaro.org>
On Sat, Apr 13, 2024 at 12:43:38PM +0200, Krzysztof Kozlowski wrote:
> On 13/04/2024 12:34, Lukas Wunner wrote:
> > The other patch just adds an entry to of_tis_i2c_match[] in the driver,
> > pretty unspectacular:
> >
> > https://lore.kernel.org/all/20240413071621.12509-2-michael.haener@siemens.com/
>
> Then why is it needed?
The binding requires two entries in the compatible string used in the DT,
the chip name followed by the generic string:
items:
- enum:
- infineon,slb9673
- nuvoton,npct75x
- const: tcg,tpm-tis-i2c
This allows us to deal with device-specific quirks, should they pop up
(e.g. special timing requirements, hardware bugs). We don't know in
advance if they will be discovered, but if they are, it's cumbersome
to determine after the fact which products (and thus DTs) are affected.
So having the name of the actual chip used on the board has value.
Thanks,
Lukas
next prev parent reply other threads:[~2024-04-13 10:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 7:15 [PATCH 0/2] Add ST33KTPM2XI2C chip to the TPM TIS I2C driver M. Haener
2024-04-13 7:15 ` [PATCH 1/2] tpm: tis_i2c: Add compatible string st,st33ktpm2xi2c M. Haener
2024-04-13 21:45 ` Jarkko Sakkinen
2024-04-13 7:15 ` [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding M. Haener
2024-04-13 8:10 ` Krzysztof Kozlowski
2024-04-13 10:18 ` Lukas Wunner
2024-04-13 10:23 ` Krzysztof Kozlowski
2024-04-13 10:34 ` Lukas Wunner
2024-04-13 10:43 ` Krzysztof Kozlowski
2024-04-13 10:51 ` Lukas Wunner [this message]
2024-04-13 10:53 ` Krzysztof Kozlowski
2024-04-13 10:56 ` Lukas Wunner
2024-04-13 11:01 ` Krzysztof Kozlowski
2024-04-14 5:42 ` Haener, Michael
2024-04-14 5:52 ` Krzysztof Kozlowski
2024-04-13 21:49 ` Jarkko Sakkinen
2024-04-13 8:38 ` Krzysztof Kozlowski
2024-04-13 20:26 ` Haener, Michael
2024-04-13 21:13 ` Krzysztof Kozlowski
2024-04-13 21:47 ` Jarkko Sakkinen
2024-04-13 21:48 ` Krzysztof Kozlowski
2024-04-13 21:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhpjozjbeWrb0OTl@wunner.de \
--to=lukas@wunner.de \
--cc=alexander.sverdlin@siemens.com \
--cc=conor+dt@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.haener@siemens.com \
--cc=peterhuewe@gmx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox