From: Lukas Wunner <lukas@wunner.de>
To: Vitor Soares <ivitro@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Vitor Soares <vitor.soares@toradex.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry
Date: Sat, 22 Jun 2024 11:07:44 +0200 [thread overview]
Message-ID: <ZnaUYICRxvSG-sTX@wunner.de> (raw)
In-Reply-To: <20240621095045.1536920-1-ivitro@gmail.com>
[removing stable@vger.kernel.org from cc -- they're only interested
in your patch once it's in Linus' tree]
On Fri, Jun 21, 2024 at 10:50:45AM +0100, Vitor Soares wrote:
> "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> allowing module autoloading and leading to the following message:
>
> "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
[...]
> Fix this by adding the corresponding "attpm20p" spi_device_id entry.
>
> Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
The old problem that spi modules aren't auto-loaded based on
MODULE_DEVICE_TABLE(of, ...), but only on MODULE_DEVICE_TABLE(spi, ...):
https://lore.kernel.org/all/20170811081429.GA9957@wunner.de/
Completely forgot that this is still a problem after all these years. :(
Thanks,
Lukas
next prev parent reply other threads:[~2024-06-22 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 9:50 [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry Vitor Soares
2024-06-22 9:07 ` Lukas Wunner [this message]
2024-07-01 15:02 ` Jarkko Sakkinen
2024-07-01 15:14 ` Francesco Dolcini
2024-07-01 15:27 ` Jarkko Sakkinen
2024-07-01 15:28 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnaUYICRxvSG-sTX@wunner.de \
--to=lukas@wunner.de \
--cc=ivitro@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=vitor.soares@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox