* [PATCH][next] tpm: remove kmalloc failure error message
@ 2025-04-29 17:14 Colin Ian King
2025-04-29 18:42 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2025-04-29 17:14 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, linux-integrity
Cc: kernel-janitors, linux-kernel
The kmalloc failure message is just noise. Remove it.
---
V2: remove entire message, originally just removed a trailing space
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/char/tpm/eventlog/tpm1.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
index 12ee42a31c71..773e9e537991 100644
--- a/drivers/char/tpm/eventlog/tpm1.c
+++ b/drivers/char/tpm/eventlog/tpm1.c
@@ -257,11 +257,8 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
(unsigned char *)(v + sizeof(struct tcpa_event));
eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
- if (!eventname) {
- printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
- __func__);
+ if (!eventname)
return -EFAULT;
- }
/* 1st: PCR */
seq_printf(m, "%2d ", do_endian_conversion(event->pcr_index));
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] tpm: remove kmalloc failure error message
2025-04-29 17:14 [PATCH][next] tpm: remove kmalloc failure error message Colin Ian King
@ 2025-04-29 18:42 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2025-04-29 18:42 UTC (permalink / raw)
To: Colin Ian King, Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe,
linux-integrity
Cc: kernel-janitors, linux-kernel
Le 29/04/2025 à 19:14, Colin Ian King a écrit :
> The kmalloc failure message is just noise. Remove it.
>
> ---
>
> V2: remove entire message, originally just removed a trailing space
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Hi,
The S-o-b tag is not correctly placed.
CJ
> ---
> drivers/char/tpm/eventlog/tpm1.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..773e9e537991 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -257,11 +257,8 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
> (unsigned char *)(v + sizeof(struct tcpa_event));
>
> eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
> - if (!eventname) {
> - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> - __func__);
> + if (!eventname)
> return -EFAULT;
> - }
>
> /* 1st: PCR */
> seq_printf(m, "%2d ", do_endian_conversion(event->pcr_index));
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-29 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 17:14 [PATCH][next] tpm: remove kmalloc failure error message Colin Ian King
2025-04-29 18:42 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).