From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6D7C7EE23 for ; Wed, 24 May 2023 08:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240018AbjEXIog (ORCPT ); Wed, 24 May 2023 04:44:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240271AbjEXIof (ORCPT ); Wed, 24 May 2023 04:44:35 -0400 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86A65196; Wed, 24 May 2023 01:44:31 -0700 (PDT) Received: from [192.168.0.185] (unknown [95.90.238.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id CFF5F61DFA909; Wed, 24 May 2023 10:43:26 +0200 (CEST) Message-ID: Date: Wed, 24 May 2023 10:43:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only Content-Language: en-US To: Peter Ujfalusi References: <20230524055815.10165-1-peter.ujfalusi@linux.intel.com> Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, l.sanfilippo@kunbus.com, jsnitsel@redhat.com From: Paul Menzel In-Reply-To: <20230524055815.10165-1-peter.ujfalusi@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Dear Peter, Thank you for your patch. Am 24.05.23 um 07:58 schrieb Peter Ujfalusi: > The original patch which added the quirk would apply to all AAEON machines, > which might or might not be valid. > > The issue was discovered on UPX-i11 (TigerLake), it is not known if the > i12 (AlderLake) version is affected. > UP2 (ApolloLake) does not even have TMP module (no TPM drivers probing s/TMP/TPM/ > and confirmed by dmidecode). Another nit, the official spelling of the SOC names is with a space, for example, Tiger Lake [1]. > Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only. > > Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11") > Suggested-by: Jerry Snitselaar > Signed-off-by: Peter Ujfalusi > --- > Hi Jarkko, > > the patch is generated on top of your > git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm > > Regards, > Peter > > drivers/char/tpm/tpm_tis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 7db3593941ea..4357d4ba8f9e 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > .ident = "UPX-TGL", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "AAEON"), > + DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"), > }, > }, > {} Reviewed-by: Paul Menzel Kind regards, Paul [1]: https://en.wikipedia.org/wiki/Tiger_Lake