public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Pengfei Xu <pengfei.xu@intel.com>
Cc: linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	linux-kernel@vger.kernel.org, heng.su@intel.com
Subject: Re: [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM drivers
Date: Thu, 27 Apr 2023 13:52:00 +0300	[thread overview]
Message-ID: <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org> (raw)
In-Reply-To: <ZEnWykDF6kbZ8nVi@xpf.sh.intel.com>

On Thu, 2023-04-27 at 09:58 +0800, Pengfei Xu wrote:
> On 2023-04-26 at 21:58:33 +0300, Jarkko Sakkinen wrote:
> > TPM chip bootstrapping was removed from tpm_chip_register(), and it
> > was relocated to tpm_tis_core. This breaks all drivers which are not
> > based on tpm_tis because the chip will not get properly initialized.
> > 
> > Take the corrective steps:
> > 1. Rename tpm_chip_startup() as tpm_chip_bootstrap() and make it one-shot.
> > 2. Call tpm_chip_bootstrap() in tpm_chip_register(), which reverts the
> >    things  as tehy used to be.
>            ^ two space and one typo "they"
> 	   Thanks for your fixed patch in short time!
> 
>   And I tested this patch, it could not be reproduced in 155s, and the patch
>   fixed this issue.
>   Fixed dmesg is in attached.
> 
> Tested-by: Pengfei Xu <pengfei.xu@intel.com>

Thanks a lot! I'll take immediate action to send PR to Linus.

Lino: no worries. It was expected that such a large refactorization
could break a thing or two. You did a good job in any case.

BR, Jarkko

  parent reply	other threads:[~2023-04-27 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 18:58 [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM drivers Jarkko Sakkinen
     [not found] ` <ZEnWykDF6kbZ8nVi@xpf.sh.intel.com>
2023-04-27 10:52   ` Jarkko Sakkinen [this message]
2023-04-27 11:12     ` Jarkko Sakkinen
2023-04-27 15:33     ` Lino Sanfilippo
2023-04-27 17:26       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org \
    --to=jarkko@kernel.org \
    --cc=heng.su@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pengfei.xu@intel.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox