From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF728C4363A for ; Fri, 23 Oct 2020 12:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 653AD21D43 for ; Fri, 23 Oct 2020 12:46:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="dhEE20Xf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S464009AbgJWMqK (ORCPT ); Fri, 23 Oct 2020 08:46:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52390 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S463977AbgJWMqJ (ORCPT ); Fri, 23 Oct 2020 08:46:09 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09NCWLX4171125 for ; Fri, 23 Oct 2020 08:46:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=6I1SrkJ+djDEZ8+7gK/ZHFxY7puWxVsYjSIyFn7Cv+w=; b=dhEE20XfWK8chfxEOSy8rHcM0RiiIHbipraITVeUGud4KSgpzG5rQE0Nb8iV1n0vpny6 2l+nY1B52UR2eCUcme7MaKcwEwT27x2U7zFfOriYXXN6HClkb/wnKk7GNahvUKf1zbzi LyPxvWPB3zpWPKdE2hDlM6PaHisp3PmQgm6B/V9g5Uo4//dvcw/LTO9xH9SrS1GtGHEF QwHNLIJ52izim+YiIXckrOioMMsadD1fLeMH2aqznbhj+nMj+0LHBaIjia01vSz1CULd Mh0rGJisDYtctiZQwVXnvraXljI1f2ghbHmBV5FHtCcaNjQO/obOvDZuSr2mKlBDFRzs 6w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34bx0rtkw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 23 Oct 2020 08:46:09 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 09NCXm0W175802 for ; Fri, 23 Oct 2020 08:46:08 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 34bx0rtkus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Oct 2020 08:46:08 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 09NCSB7Y000482; Fri, 23 Oct 2020 12:46:06 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03fra.de.ibm.com with ESMTP id 347r87ue68-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Oct 2020 12:46:05 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 09NCk3ap33292702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Oct 2020 12:46:03 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9217552054; Fri, 23 Oct 2020 12:46:03 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.160.127.13]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4F85652052; Fri, 23 Oct 2020 12:46:02 +0000 (GMT) Message-ID: Subject: Re: [PATCH ima-evm-utils] boot_aggregate.test: Skip if CONFIG_IMA not enabled From: Mimi Zohar To: Petr Vorel , linux-integrity@vger.kernel.org Cc: Mimi Zohar , Dmitry Eremin-Solenikov Date: Fri, 23 Oct 2020 08:46:01 -0400 In-Reply-To: References: <20201019200803.35255-1-petr.vorel@gmail.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-12.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.737 definitions=2020-10-23_04:2020-10-23,2020-10-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010230086 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Petr, On Mon, 2020-10-19 at 19:10 -0400, Mimi Zohar wrote: > On Mon, 2020-10-19 at 22:08 +0200, Petr Vorel wrote: > > This is required, because when TPM HW available (i.e. -c /dev/tpm0), > > evmctl ima_boot_aggregate returns sha1:xxxx. > > > > skip requires to move cleanup(). > > > > Signed-off-by: Petr Vorel > > Nice. > > --- > > Hi Mimi, > > > > this Fixes problems on current Debian, which has still disabled CONFIG_IMA > > (FYI [1]). I was not able to figure out how to get it working with > > sample-* files, but maybe there is a way. Moving the test down to within "if [ "$(id -u)" = 0 ] && [ -c "/dev/tpm0" ]; then" will allow the sample tests to work. I've modified your patch and pushed it out to next-testing. thanks, Mimi