linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Denis Aleksandrov <daleksan@redhat.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
	Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCH] tpm: prevents local DOS via tpm/tpm0/ppi/*operations
Date: Wed, 13 Aug 2025 10:48:21 +0300	[thread overview]
Message-ID: <aJxDRb5KJUTc-dL9@kernel.org> (raw)
In-Reply-To: <CAG+gbFfY=YZZ24dZpBtShc+4ypGJgngsz7X32XKaHZ90s3okFg@mail.gmail.com>

On Tue, Aug 12, 2025 at 05:13:32PM -0400, Denis Aleksandrov wrote:
> Hi Jarkko,
> 
> Thanks again for taking the time to review this patch.
> 
> Regarding the `Closes:` tag warning, this issue is linked to an internal Red
> Hat page, which is why 
> it was omitted. Therefore, this warning might need to be ignored.
> 
> For the other warnings, I considered using either symbolic or octal permissions
> before submitting the
> patch. I decided on symbolic permissions because that style is used
> consistently throughout
> `drivers/char/tpm/tpm_ppi.c`.
> 
> When I tried changing the permissions to octal format, `scripts/checkpatch.pl
> --strict` still flagged those
> lines with the following warnings:
> 
> ```
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to
> the report
> #13:
> Reported-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Denis Aleksandrov <daleksan@redhat.com>

Lemme check today, if I could give some feedback and help out with
this.

BTW could you use plain text in your emails? I know kernel people who
drop automatically HTML on this address. It's cool, I'm tolerant but
it's the standard :-)

There's a page for this too:

https://www.kernel.org/doc/html/latest/process/email-clients.html

Also, vger drops HTML mails, meaning that this response will arrive
there but your response that I'm responding most likely not (at least
vger used behave this way).

BR, Jarkko

  parent reply	other threads:[~2025-08-13  7:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 20:28 [PATCH] tpm: prevents local DOS via tpm/tpm0/ppi/*operations Denis Aleksandrov
2025-07-02 22:46 ` Jarkko Sakkinen
     [not found]   ` <CAG+gbFfKLCQND-TT8DEZ09T=Nhb39_CJfM5imv341Pen03bHjw@mail.gmail.com>
2025-07-03 12:00     ` Denis Aleksandrov
2025-08-08 18:32       ` Denis Aleksandrov
2025-08-09 10:51         ` Jarkko Sakkinen
2025-08-12 16:03         ` Jarkko Sakkinen
     [not found]           ` <CAG+gbFfY=YZZ24dZpBtShc+4ypGJgngsz7X32XKaHZ90s3okFg@mail.gmail.com>
2025-08-13  7:48             ` Jarkko Sakkinen [this message]
2025-08-13 13:13               ` Denis Aleksandrov
2025-08-14  7:37                 ` Jarkko Sakkinen
2025-08-14 14:35                   ` Denis Aleksandrov
2025-08-18 17:40         ` Jarkko Sakkinen
2025-08-18 19:12           ` Denis Aleksandrov
2025-08-19 22:38             ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJxDRb5KJUTc-dL9@kernel.org \
    --to=jarkko@kernel.org \
    --cc=daleksan@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jstancek@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).