From: Jarkko Sakkinen <jarkko@kernel.org>
To: Denis Aleksandrov <daleksan@redhat.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCH v2] tpm: prevents local DOS via tpm/tpm0/ppi/*operations
Date: Wed, 27 Aug 2025 15:45:50 +0300 [thread overview]
Message-ID: <aK79_nYY01rFvUAt@kernel.org> (raw)
In-Reply-To: <20250827022102.17731-1-daleksan@redhat.com>
On Tue, Aug 26, 2025 at 10:21:02PM -0400, Denis Aleksandrov wrote:
> Reads on tpm/tpm0/ppi/*operations can become very long on
> misconfigured systems. Reading the TPM is a blocking operation,
> thus a user could effectively trigger a DOS.
>
> Resolve this by caching the results and avoiding the blocking
> operations after the first read.
>
> Reported-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Denis Aleksandrov <daleksan@redhat.com>
I can already say that this definitely to the right direction. Thanks
for taking time revisiting this, and taking time to restructure it.
I'll give more detailed review later on. One nitpick:
Suggested-by: Jarkko Sakkinen <jarkko@kernel.org>
You put this whenever the proposal for "final solution" comes from
an outside source. It's a good practice, and it's not only for the
credit, but also to get to the blame if my proposal turns out to
be an epic failure ;-)
But yeah, hold on for detailed review.
BR, Jarkko
prev parent reply other threads:[~2025-08-27 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 2:21 [PATCH v2] tpm: prevents local DOS via tpm/tpm0/ppi/*operations Denis Aleksandrov
2025-08-27 5:55 ` Paul Menzel
2025-08-27 12:48 ` Jarkko Sakkinen
2025-08-28 15:35 ` Denis Aleksandrov
2025-08-28 23:54 ` Jarkko Sakkinen
2025-08-30 10:41 ` Paul Menzel
2025-08-27 12:45 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK79_nYY01rFvUAt@kernel.org \
--to=jarkko@kernel.org \
--cc=daleksan@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jstancek@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).