From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-integrity@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@opinsys.com>,
David Howells <dhowells@redhat.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Mimi Zohar <zohar@linux.ibm.com>,
"open list:KEYS/KEYRINGS" <keyrings@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] keys, trusted: Remove redundant helper
Date: Wed, 24 Sep 2025 20:12:36 +0300 [thread overview]
Message-ID: <aNQmhIFpnoKQP1W1@kernel.org> (raw)
In-Reply-To: <aNOr4_xLQ30iTRSe@earth.li>
On Wed, Sep 24, 2025 at 09:29:23AM +0100, Jonathan McDowell wrote:
> On Mon, Sep 22, 2025 at 07:43:17PM +0300, Jarkko Sakkinen wrote:
> > From: Jarkko Sakkinen <jarkko.sakkinen@opinsys.com>
> >
> > tpm2_buf_append_auth has only single call site and most of its parameters
> > are redundant. Open code it to the call site. Remove illegit FIXME comment
> > as there is no categorized bug and replace it with more sane comment about
> > implementation (i.e. "non-opionated inline comment").
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@opinsys.com>
>
> Seems like a reasonable cleanup.
>
> Reviewed-by: Jonathan McDowell <noodles@earth.li>
Thank you!
BTW, I applied your patches to master:
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/
I did not yet bother to test them other than compilation and checkpatch
but I'm testing this and tpm_buf-series so they will get a lot of stress
testing. I'll rebase 'next' once they are actually tested (before PR).
BR, Jarkko
prev parent reply other threads:[~2025-09-24 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 16:43 [PATCH 0/4] tpm2-session: correct disperancies Jarkko Sakkinen
2025-09-22 16:43 ` [PATCH 1/4] tpm: Use -EPERM as fallback error code in tpm_ret_to_err Jarkko Sakkinen
2025-09-24 8:32 ` Jonathan McDowell
2025-09-24 17:16 ` Jarkko Sakkinen
2025-09-22 16:43 ` [PATCH 2/4] tpm2-sessions: Remove unused parameter from tpm_buf_append_auth Jarkko Sakkinen
2025-09-24 8:47 ` Jonathan McDowell
2025-09-24 17:18 ` Jarkko Sakkinen
2025-09-22 16:43 ` [PATCH 3/4] tpm2-sessions: Remove unnecessary wrapper Jarkko Sakkinen
2025-09-22 17:22 ` Ben Boeckel
2025-09-23 14:45 ` Jarkko Sakkinen
2025-09-22 16:43 ` [PATCH 4/4] keys, trusted: Remove redundant helper Jarkko Sakkinen
2025-09-24 8:29 ` Jonathan McDowell
2025-09-24 17:12 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNQmhIFpnoKQP1W1@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=jarkko.sakkinen@opinsys.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=noodles@earth.li \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).