[PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Uwe Kleine-König]

Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
function name but I failed to adapt the kernel doc when doing so. This
change aligns the kernel doc to the actual function name (again).

Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
---
 drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
index 20294d1953a3..b82490439633 100644
--- a/drivers/char/tpm/tpm_ftpm_tee.c
+++ b/drivers/char/tpm/tpm_ftpm_tee.c
@@ -163,7 +163,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
 }
 
 /**
- * ftpm_tee_probe() - initialize the fTPM
+ * ftpm_tee_probe_generic() - initialize the fTPM
  * @dev: the device description.
  *
  * Return:
@@ -266,7 +266,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
 }
 
 /**
- * ftpm_tee_remove() - remove the TPM device
+ * ftpm_tee_remove_generic() - remove the TPM device
  * @dev: the device description.
  *
  * Return:

base-commit: 92fad96aea24fc19abe1eae2249402b61de3a3e2
-- 
2.47.3

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Jens Wiklander]

On Tue, Jan 13, 2026 at 3:38 PM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> function name but I failed to adapt the kernel doc when doing so. This
> change aligns the kernel doc to the actual function name (again).
>
> Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> ---
>  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me. Jarkko, OK, if I also take this patch via my tree?

Cheers,
Jens

>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 20294d1953a3..b82490439633 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -163,7 +163,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
>  }
>
>  /**
> - * ftpm_tee_probe() - initialize the fTPM
> + * ftpm_tee_probe_generic() - initialize the fTPM
>   * @dev: the device description.
>   *
>   * Return:
> @@ -266,7 +266,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
>  }
>
>  /**
> - * ftpm_tee_remove() - remove the TPM device
> + * ftpm_tee_remove_generic() - remove the TPM device
>   * @dev: the device description.
>   *
>   * Return:
>
> base-commit: 92fad96aea24fc19abe1eae2249402b61de3a3e2
> --
> 2.47.3
>

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Jarkko Sakkinen]

On Wed, Jan 14, 2026 at 07:47:09AM +0100, Jens Wiklander wrote:
> On Tue, Jan 13, 2026 at 3:38 PM Uwe Kleine-König
> <u.kleine-koenig@baylibre.com> wrote:
> >
> > Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> > function name but I failed to adapt the kernel doc when doing so. This
> > change aligns the kernel doc to the actual function name (again).
> >
> > Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> > ---
> >  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Looks good to me. Jarkko, OK, if I also take this patch via my tree?

Works for me that way too with my r-by tag.

> 
> Cheers,
> Jens
> 
> >
> > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> > index 20294d1953a3..b82490439633 100644
> > --- a/drivers/char/tpm/tpm_ftpm_tee.c
> > +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> > @@ -163,7 +163,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
> >  }
> >
> >  /**
> > - * ftpm_tee_probe() - initialize the fTPM
> > + * ftpm_tee_probe_generic() - initialize the fTPM
> >   * @dev: the device description.
> >   *
> >   * Return:
> > @@ -266,7 +266,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
> >  }
> >
> >  /**
> > - * ftpm_tee_remove() - remove the TPM device
> > + * ftpm_tee_remove_generic() - remove the TPM device
> >   * @dev: the device description.
> >   *
> >   * Return:
> >
> > base-commit: 92fad96aea24fc19abe1eae2249402b61de3a3e2
> > --
> > 2.47.3
> >

BR, Jarkko

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Jens Wiklander]

On Wed, Jan 14, 2026 at 4:58 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> On Wed, Jan 14, 2026 at 07:47:09AM +0100, Jens Wiklander wrote:
> > On Tue, Jan 13, 2026 at 3:38 PM Uwe Kleine-König
> > <u.kleine-koenig@baylibre.com> wrote:
> > >
> > > Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> > > function name but I failed to adapt the kernel doc when doing so. This
> > > change aligns the kernel doc to the actual function name (again).
> > >
> > > Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> > > ---
> > >  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Looks good to me. Jarkko, OK, if I also take this patch via my tree?
>
> Works for me that way too with my r-by tag.

Thanks, it's there now.

Cheers,
Jens

>
> >
> > Cheers,
> > Jens
> >
> > >
> > > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> > > index 20294d1953a3..b82490439633 100644
> > > --- a/drivers/char/tpm/tpm_ftpm_tee.c
> > > +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> > > @@ -163,7 +163,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
> > >  }
> > >
> > >  /**
> > > - * ftpm_tee_probe() - initialize the fTPM
> > > + * ftpm_tee_probe_generic() - initialize the fTPM
> > >   * @dev: the device description.
> > >   *
> > >   * Return:
> > > @@ -266,7 +266,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
> > >  }
> > >
> > >  /**
> > > - * ftpm_tee_remove() - remove the TPM device
> > > + * ftpm_tee_remove_generic() - remove the TPM device
> > >   * @dev: the device description.
> > >   *
> > >   * Return:
> > >
> > > base-commit: 92fad96aea24fc19abe1eae2249402b61de3a3e2
> > > --
> > > 2.47.3
> > >
>
> BR, Jarkko

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

On Thu, Jan 15, 2026 at 09:06:35AM +0100, Jens Wiklander wrote:
> On Wed, Jan 14, 2026 at 4:58 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > On Wed, Jan 14, 2026 at 07:47:09AM +0100, Jens Wiklander wrote:
> > > On Tue, Jan 13, 2026 at 3:38 PM Uwe Kleine-König
> > > <u.kleine-koenig@baylibre.com> wrote:
> > > >
> > > > Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> > > > function name but I failed to adapt the kernel doc when doing so. This
> > > > change aligns the kernel doc to the actual function name (again).
> > > >
> > > > Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> > > > ---
> > > >  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Looks good to me. Jarkko, OK, if I also take this patch via my tree?
> >
> > Works for me that way too with my r-by tag.
> 
> Thanks, it's there now.

Stephen pointed out that I forgot to add my S-o-b[1]. So I hereby certify
that I created the patch and have the right to submit it under the GPL2.

With that I think it's technically ok that the commit doesn't have my
S-o-b. But if you are willing to rewrite the commit still, please add
it:

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Sorry for the mess,
Uwe

[1] https://lore.kernel.org/all/20260115075340.72b35a93@canb.auug.org.au/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Jens Wiklander]

On Thu, Jan 15, 2026 at 9:29 AM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> On Thu, Jan 15, 2026 at 09:06:35AM +0100, Jens Wiklander wrote:
> > On Wed, Jan 14, 2026 at 4:58 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> > >
> > > On Wed, Jan 14, 2026 at 07:47:09AM +0100, Jens Wiklander wrote:
> > > > On Tue, Jan 13, 2026 at 3:38 PM Uwe Kleine-König
> > > > <u.kleine-koenig@baylibre.com> wrote:
> > > > >
> > > > > Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> > > > > function name but I failed to adapt the kernel doc when doing so. This
> > > > > change aligns the kernel doc to the actual function name (again).
> > > > >
> > > > > Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> > > > > ---
> > > > >  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > Looks good to me. Jarkko, OK, if I also take this patch via my tree?
> > >
> > > Works for me that way too with my r-by tag.
> >
> > Thanks, it's there now.
>
> Stephen pointed out that I forgot to add my S-o-b[1]. So I hereby certify
> that I created the patch and have the right to submit it under the GPL2.
>
> With that I think it's technically ok that the commit doesn't have my
> S-o-b. But if you are willing to rewrite the commit still, please add
> it:
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

I've updated it.

Thanks,
Jens

Re: [PATCH] tpm/tpm_ftpm_tee: Fix kdoc after function renames

[Jarkko Sakkinen]

On Tue, Jan 13, 2026 at 03:38:15PM +0100, Uwe Kleine-König wrote:
> Recently ftpm_tee_probe() and ftpm_tee_remove() grew a suffix in their
> function name but I failed to adapt the kernel doc when doing so. This
> change aligns the kernel doc to the actual function name (again).
> 
> Fixes: 92fad96aea24 ("tpm/tpm_ftpm_tee: Make use of tee bus methods")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601132105.9lgSsC4U-lkp@intel.com/
> ---
>  drivers/char/tpm/tpm_ftpm_tee.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 20294d1953a3..b82490439633 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -163,7 +163,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
>  }
>  
>  /**
> - * ftpm_tee_probe() - initialize the fTPM
> + * ftpm_tee_probe_generic() - initialize the fTPM
>   * @dev: the device description.
>   *
>   * Return:
> @@ -266,7 +266,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
>  }
>  
>  /**
> - * ftpm_tee_remove() - remove the TPM device
> + * ftpm_tee_remove_generic() - remove the TPM device
>   * @dev: the device description.
>   *
>   * Return:
> 
> base-commit: 92fad96aea24fc19abe1eae2249402b61de3a3e2
> -- 
> 2.47.3
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko