From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A9AC377ED7; Tue, 3 Mar 2026 21:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573214; cv=none; b=dB705FTUPEN47PR8dRL4N9LQrEx5NGKBcH4EKcZYn9AuPZM6V/0++bwGb+Fq0L/w5SgQ6PXbAjOnCHtXRdfp4hkzl/joTeMghkrao3afhzTVxnNdqm44hbr4jPaFuQrgx16Y4Ny/ABJHh0iVgSO2rK943QpLlEPvSTvUhQa7Nxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573214; c=relaxed/simple; bh=o8qtxAvcpI27fXxm+YDkyazulCEfeVWfNjp8JBioi+8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QwrKCBikAvIrl10ytWX0/tri0qnMvWUKjF81+6X5796EkH71tHmPR51m9xTjNwB2Ia2UyXLDDJSoPWv3iUM98EYopd3US0YcmlPK6KP4hdKixOet9pgQYdILeMHxwrOgXN0zqpC27sq+7zSQbjaifVZnDQK2VTedkKkGXeuWXwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DFM+J3nM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DFM+J3nM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FD82C116C6; Tue, 3 Mar 2026 21:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772573213; bh=o8qtxAvcpI27fXxm+YDkyazulCEfeVWfNjp8JBioi+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DFM+J3nMaee3cMzTxWiyLn1yDX8TvzPu1+qxXPbRNEMs9mq56KljD7+GaaHLYtsdp 5ksDCK5WD+4yr93n0cB6ap+sj15CCVBZJeI7ITdnM45zBdXtZQaj517lyz8XP4L5i0 LeExIZv4uKOM6aMGeYvxFX7OOskXH/O7YFThl5UijKy/SUYpP7kU3YFh1OXiH+oK85 RGZ2Ag5wNAmSqv7W9B5V+CdTjiuiNLjirui/93B3UquUTLpaSEaAEV1I7EWPVmEP9M nfzSCK/9D7DZ+Ghi6w0UCkQl+5axboIQmX+Dcns5zSZUGQwBNRw/olm0fLlFCZJalF efGr6HO5wMeQw== Date: Tue, 3 Mar 2026 23:26:49 +0200 From: Jarkko Sakkinen To: Krzysztof Kozlowski Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: Make tcpci_pm_ops variable static const Message-ID: References: <20260216110458.160357-2-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-integrity@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260216110458.160357-2-krzysztof.kozlowski@oss.qualcomm.com> On Mon, Feb 16, 2026 at 12:04:59PM +0100, Krzysztof Kozlowski wrote: > File-scope 'tcpci_pm_ops' is not used outside of this unit and is not > modified anywhere, so make it static const to silence sparse warning: > > tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static? > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/char/tpm/tpm2-cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > index 3a77be7ebf4a..e00f668f8c84 100644 > --- a/drivers/char/tpm/tpm2-cmd.c > +++ b/drivers/char/tpm/tpm2-cmd.c > @@ -21,7 +21,7 @@ static bool disable_pcr_integrity; > module_param(disable_pcr_integrity, bool, 0444); > MODULE_PARM_DESC(disable_pcr_integrity, "Disable integrity protection of TPM2_PCR_Extend"); > > -struct tpm2_hash tpm2_hash_map[] = { > +static const struct tpm2_hash tpm2_hash_map[] = { > {HASH_ALGO_SHA1, TPM_ALG_SHA1}, > {HASH_ALGO_SHA256, TPM_ALG_SHA256}, > {HASH_ALGO_SHA384, TPM_ALG_SHA384}, > -- > 2.51.0 > Applied. Reviewed-by: Jarkko Sakkinen BR, Jarkko