From: Jarkko Sakkinen <jarkko@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
keyrings@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [GIT PULL] KEYS: keys-next-7.1-rc1
Date: Mon, 20 Apr 2026 01:08:45 +0300 [thread overview]
Message-ID: <aeVSbVIFaCDRXf7C@kernel.org> (raw)
In-Reply-To: <CAHk-=wjaGOBCsRpEhmPLcsuK6ggiaaeyz0rT6x3Zv7DMK7JNHA@mail.gmail.com>
On Sun, Apr 19, 2026 at 02:52:06PM -0700, Linus Torvalds wrote:
> On Sun, 19 Apr 2026 at 14:38, Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > I tested both PRs for the same baseline with two separate buildroot builds of
>
> You threw away any and all testing that had been done by anybody else
> in linux-next.
>
> And you rebased things on top of a random commit-of-the-day during the
> merge window, when things are possibly unstable due to all the *other*
> churn going on.
>
> In other words, you did *EVERYTHING* that you shouldn't be doing, and
> that the documentation tells you not to do.
>
> The WHOLE POINT of being in linux-next and being ready when the merge
> window opens is gone. All for apparently nothing.
>
> Those stable cc tags do not add *any* value, since you could just have
> cc'd stable later instead.
>
> I'm not pulling this. You need to stop doing this pointless churn, and
> read the docs on rebasing. See
>
> Documentation/maintainer/rebasing-and-merging.rst
>
> about how you are *not* supposed to randomly just rebase, and
> _particularly_ not rebase on top of some random state during the merge
> window.
"A frequent cause of merge-window trouble is when Linus is presented with a
patch series that has clearly been reparented, often to a random commit,
shortly before the pull request was sent. The chances of such a series
having been adequately tested are relatively low - as are the chances of
the pull request being acted upon."
OK, point digested.
I can update 'next' to contain only fixes from these PRs, and hold on up
til doing PR for -rc2 (as corrective step).
>
> Linus
BR, Jarkko
prev parent reply other threads:[~2026-04-19 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 12:34 [GIT PULL] KEYS: keys-next-7.1-rc1 Jarkko Sakkinen
2026-04-19 15:43 ` Linus Torvalds
2026-04-19 21:38 ` Jarkko Sakkinen
2026-04-19 21:52 ` Linus Torvalds
2026-04-19 22:08 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeVSbVIFaCDRXf7C@kernel.org \
--to=jarkko@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox